Vote #70402
未完了Activity page not refreshed correctly on updates which are not events
0%
説明
Since of r2982, any updates made to issues (among others, see #5425 or #5749) which are not handled as @events@, like Description update or even move to a different Tracker, won't be seen in the activity report if you refresh the page.
So you'll see potentially wrong description and wrong tracker in issue events labels.
Couldn't we get rid of the @stale?@ check ?
It does not prevent the events to be fetched from db and the activity report can be big, but maybe not that big (about 61k for current Redmine activity).
journals
Etienne Massip wrote:
> It does not prevent the events to be fetched from db and the activity report can be _big_, but maybe not that big (about 61k for current Redmine activity).
Indeed but it prevents the view rendering which is about 75% of the total response time on this page. That means 4x faster which is appreciable on large activity views.
Maybe an option to turn it on/off in application settings.
--------------------------------------------------------------------------------
BTW, I'm wondering if the ETag check should apply to API calls too?
--------------------------------------------------------------------------------
Same issue if you delete a forum message, it still appears in activity page.
--------------------------------------------------------------------------------
Another example :
* projects P1 & P2 revisions are fetched when clicking on Repository tab
* there are revisions not yet fetched in P2 which are older than P1 latest revision
* the global activity page including revision events won't display the P2 revisions (since not yet fetched)
* you click on the Repository tab of P2, P2 revisions are now fetched into RM DB
+1st issue:+ the activity page still doesn't display P2 revisions, because P1 latest revision is more recent than newly fetched P2 revisions and so ETag value will remain the same
+2nd issue:+ if you add, e.g., time tracking events (by checking the checkbox and clicking the 'Apply' button), you'll see P2 revisions (ETag value has changed). Then if you deselect again time tracking events, P2 revisions will disappear (ETag is back to its first value).
--------------------------------------------------------------------------------
related_issues
relates,Closed,5425,Showing date in activity page is wrong
relates,New,5749,ETag on activity page ignores module, theme, project name changes
relates,Closed,1048,Day grouping on Activity view ignores user's time zone