Vote #70961: Show locked badge for locked wiki pages - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #70961

完了

Show locked badge for locked wiki pages

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Wiki_1

対象バージョン:

4.1.0_127

開始日:

2011/11/22

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/9634

category_id:

version_id:

127

issue_org_id:

9634

author_id:

44932

assigned_to_id:

332

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

At the moment, wiki pages (such as the http://redmine.org/ homepage), for users without editing privileges, don't display any visible control for editing the page that indicate that this is the case. As a result, one wonders why they cannot be edited and what to do about it. This is the greyed-out-menu-items issue in UI usability all over again, only worse.

Please give a visible indicator for: 1. Why it cannot be done. 2. What to do about it.

Regards,

— Shlomi Fish

journals

Can you take a screenshot or two detailing what you see. I don't see controls for editing on the redmine homepage under IE.
--------------------------------------------------------------------------------
Felix Dominguez wrote:
> Can you take a screenshot or two detailing what you see. I don't see controls for editing on the redmine homepage under IE.

That's the point - there aren't any, while there should be. I wondered how to edit the page (because it is indicated to be a wiki page), but they don't know.
--------------------------------------------------------------------------------
In this case the wiki page you were trying to edit ([[overview]]) is [[RedmineWikis#Protecting-a-wiki-page|locked]].

IMHO it would be good to have that "state" publicly visible with some sort of indicator. Perhaps re-use of the already available unlock icon can help here...
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
I think it would be nice if the locked status of a wiki page is shown next to the title, as already implemented for versions by #29391.

!{width: 345px; border: 1px solid #ccc;}.locked-version@2x.png!
--------------------------------------------------------------------------------
We cannot implement this using the solution with the badge because the title is part of the wiki page content and not a required property (sorry for my wrong proposal). It will look very weird when the user doesn't addd a title to the page, please see the below example:
!{border: 1px solid grey; }without_title.png!

What do you think if we add the information to the bottom of the page, next to "Updated by ... ago" ?

!{border: 1px solid grey; }bottom.png!

--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> What do you think if we add the information to the bottom of the page, next to "Updated by ... ago" ?

I think it is one of the ideas. But I really like the badge style you made.

IMHO it will be even nicer if the badge is used like the following. What do you think?

!{width: 766px; border: 1px solid #ccc;}.locked-badge-bottom@2x.png!
--------------------------------------------------------------------------------
Go MAEDA wrote:
>
> I think it is one of the ideas. But I really like the badge style you made.
>
> IMHO it will be even nicer if the badge is used like the following. What do you think?

Totally agree.

--------------------------------------------------------------------------------
Here is a first version of the patch, but I'm not sure regarding the permissions.

@Go Maeda, when we should show the badge?
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> Here is a first version of the patch, but I'm not sure regarding the permissions.
>
> @Go Maeda, when we should show the badge?

I don't think we have to care about permissions because the information about whether a wiki page is protected is not confidential. I think the badge should always be displayed.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Go MAEDA wrote:
> Marius BALTEANU wrote:
> > Here is a first version of the patch, but I'm not sure regarding the permissions.
> >
> > @Go Maeda, when we should show the badge?
>
> I don't think we have to care about permissions because the information about whether a wiki page is protected is not confidential. I think the badge should always be displayed.

Here is the updated patch that always shows the locked badge.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> Here is the updated patch that always shows the locked badge.

Thanks. Setting the target version to 4.1.0.
--------------------------------------------------------------------------------
Committed the patch. Thanks.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

related_issues

relates,Closed,31269,Fix Japanese translation for status_locked
duplicates,Closed,30312,Cannot know whether a wiki page is locked unless clicking the drop-down menu