Vote #71048
完了app/views/repository/_revision_graph.html.erb sets window.onload directly..
開始日:
2022/05/09
期日:
進捗率:
0%
予定工数:
Redmineorg_URL:
category_id:
3
version_id:
41
issue_org_id:
9775
author_id:
43046
assigned_to_id:
0
comments:
2
status_id:
5
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
36
説明
The subject says it all. The partial _revision_graph.html.erb (in app/views/repository) sets window.onload directly. As a result of setting window.onload directly, it toasts other onload events on the repository page (currently messing with a plugin that I have).
Instead of:
@window.onload = function() { stuff; };@
should use the prototype syntax used elsewhere in Redmine:
@Event.observe(window,"load",function(){ stuff; });@
I believe that this started showing up when I pulled down the 1.2.2 updates (not entire sure of timeline)
journals
Fixed in r8209.
--------------------------------------------------------------------------------
Merged.
--------------------------------------------------------------------------------
いいね!0