プロジェクト

全般

プロフィール

Vote #71383

完了

Add a check/uncheck all button to search

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
UI_10
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
10
version_id:
146
issue_org_id:
10264
author_id:
9214
assigned_to_id:
332
comments:
11
status_id:
5
tracker_id:
2
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

When getting search results, all items are checked. As more plugins are added, it extends the list of search items, where it would be good to have a clear all to just select the one or two that you want to search vs unchecking all.


journals

Probably we can fulfill this request by adding a green check icon ( !/images/toggle_check.png! ) to check/uncheck checkboxes, that can be seen in many pages such as Workflow and Permission report.
--------------------------------------------------------------------------------
!{width: 70%; border: 1px solid #ccc}search.png!
By changing like this, a green check icon will be added.

{{collapse(diff)
<pre><code class="diff">
diff --git a/app/views/search/index.html.erb b/app/views/search/index.html.erb
index c1ee25ce7f..5265681303 100644
--- a/app/views/search/index.html.erb
+++ b/app/views/search/index.html.erb
@@ -11,11 +11,14 @@
<label><%= check_box_tag 'titles_only', 1, @titles_only %> <%= l(:label_search_titles_only) %></label>
</p>

-<p id="search-types">
-<% @object_types.each do |t| %>
-<label><%= check_box_tag t, 1, @scope.include?(t) %> <%= link_to type_label(t), "#" %></label>
-<% end %>
-</p>
+<fieldset class="box">
+ <legend><%= toggle_checkboxes_link('p#search-types input') %></legend>
+ <p id="search-types">
+ <% @object_types.each do |t| %>
+ <label><%= check_box_tag t, 1, @scope.include?(t) %> <%= link_to type_label(t), "#" %></label>
+ <% end %>
+ </p>
+</fieldset>

<fieldset class="collapsible collapsed">
<legend onclick="toggleFieldset(this);"><%= l(:label_options) %></legend>

</code></pre>
}}
On other screens, it is label + green check icon,
but I could not think of an appropriate label on this screen.
!{width: 40%; border: 1px solid #ccc}other1.png!
!{width: 40%; border: 1px solid #ccc}other2.png!
--------------------------------------------------------------------------------
it is a small change and very useful, I propose to add it in a next minor release.

--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> it is a small change and very useful, I propose to add it in a next minor release.

I agree. Setting the target version to 4.0.2.
--------------------------------------------------------------------------------
I changed the target version to 4.0.1, but this change may break themes for 4.0 because it changes the structure of HTML (wraps @p#search-types@ with @fieldset.box@).

I think 4.1.0 is better.
--------------------------------------------------------------------------------
Committed. Thanks.
--------------------------------------------------------------------------------
This issue shows target version 4.0.2 and "changelog":https://www.redmine.org/projects/redmine/wiki/Changelog_4_0 shows it, too. But the related commit currently only exists in trunk. I think, this issue should changed to target version _4.1.0_ (as mentioned in #10264#note-5).
--------------------------------------------------------------------------------
Alexander Meindl wrote:
> This issue shows target version 4.0.2 and "changelog":https://www.redmine.org/projects/redmine/wiki/Changelog_4_0 shows it, too. But the related commit currently only exists in trunk. I think, this issue should changed to target version _4.1.0_ (as mentioned in #10264#note-5).

Indeed, the target version was never changed to 4.1.0. I'm not sure what we should do in this case, I see two options:
- we merge r17852 in 4.0-stable branch and deliver this feature in 4.0.3
- we change the target version to 4.1.0 and that's it.
--------------------------------------------------------------------------------
My recommendation is to deliver this in version:"4.0.3" (is not such a big change).
--------------------------------------------------------------------------------
Sorry for my mistake.

I have merged r17852 to 4.0-stable branch and it will be available in 4.0.3.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------


related_issues

relates,New,8680,Select all modules for search and activities

Admin Redmine さんが約4年前に更新

  • カテゴリUI_10 にセット
  • 対象バージョン4.0.2_146 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0