Vote #71875
未完了Restore comments nowrap for revisions
0%
説明
Recently upgrading from 1.3.1 to 1.4.2, I found that
+the commit comments seem to no longer truncate only the first line+ when viewed from repository menu.
Seems to be applied at r8850 "Integrated revision graph into scmid column." (in "views/repositories/revisions.html.erb":http://www.redmine.org/projects/redmine/repository/diff/trunk/app/views/repositories/_revisions.html.erb?rev=8850&type=inline ),
but can't understand why @ truncate_at_line_break(changeset.comments, 0) @ was removed.
The default length of "truncate_at_line_break is 255":http://www.redmine.org/projects/redmine/repository/revisions/8850/entry/trunk/app/helpers/repositories_helper.rb#L32 , and doesn't really help to _truncate at line without proper length given.
Is there some reason for this change?
If not, I would like to have the "first line comment only" feature back :)
Thanks.
journals
Comments were truncated to have every line the same height, it was not a feature.
IMO, truncating them was some kind of regression since you were no more able to see the whole comment text. Why would you want to see only the first line?
--------------------------------------------------------------------------------
git actually guides the users to use the first line of the log message as a subject, like in email.
<pre>
DISCUSSION
Though not required, it's a good idea to begin the commit message with
a single short (less than 50 character) line summarizing the change,
followed by a blank line and then a more thorough description. Tools
that turn commits into email, for example, use the first line on the
Subject: line and the rest of the commit in the body.
</pre>
from @git-commit@ manual page
I think it's generally a good idea to show only the one line summary of the revision when there are lot of them to list, since I can get better view of the whole, than each commits having different heights from different lines of commit logs.
For instance, "github commits page":https://github.com/torvalds/linux/commits/master shows only the first line, and have a button where you could expand to the whole message. I personally wouldn't mind if there is no expand button, since I could click the the revision and read it inside.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,New,10886,Sensitivity to git-style log messages