プロジェクト

全般

プロフィール

Vote #72076

完了

Wiki diff may generate broken HTML

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Wiki_1
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
1
version_id:
54
issue_org_id:
11209
author_id:
58128
assigned_to_id:
1
comments:
5
status_id:
5
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
52
ステータス-->[Closed]

説明

If Wiki diff has a new line (not a changed line), diff page may generates broken HTML like:

h1. CookBook documentation
Some updated [[documentation]] here...
More contents...</span>

Close @@ tag is escaped.

For example:

Before

h1. CookBook documentation
Some updated [[documentation]] here...

After:

h1. CookBook documentation
Some updated [[documentation]] here...
More contents...

"More contents..." line is added. This case, diff page generates broken HTML.


journals

I attach a patch and test case for this issue.
It adds a new fixture data. So it may break other tests. I only tested this patch against test/functional/wiki_controller_test.rb. Sorry.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Fixed in r9895 with slight changes, thanks for digging into this.
--------------------------------------------------------------------------------
Thanks!

I've also found a similar problem in Wiki update notification mail. I'll submit a new ticket with test case later.
--------------------------------------------------------------------------------
Merged.
--------------------------------------------------------------------------------


related_issues

duplicates,Closed,11735,Weird diffs in wiki pages.

Admin Redmine さんが約4年前に更新

  • カテゴリWiki_1 にセット
  • 対象バージョン2.0.4_54 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0