Vote #72191
完了Wiki diff doesn't keep spaces
0%
説明
Wiki diff page generates the following HTML:
...
sleep 10
end ...
And here is @div.text-diff@ style:
.text-diff {
padding: 1em;
background-color:#f6f6f6;
color:#505050;
border: 1px solid #e4e4e4;
}
From: source:tags/2.0.3/public/stylesheets/application.css#L777
Spaces in Wiki page are ignored because the HTML doesn't use @<pre>@ tag and the CSS also doesn't use @white-space: pre@.
journals
Here is a patch that removes @simple_format_without_paragraph@ and surrounds @@diff.to_html@ with @<pre class="text-diff">@ instead of @<div class="text-diff">@.
--------------------------------------------------------------------------------
*Before:*
!{width: 355px; border: 1px solid #ccc;}.11359-before@2x.png!
*After:*
!{width: 355px; border: 1px solid #ccc;}.11359-after@2x.png!
--------------------------------------------------------------------------------
I think it would be better to add @white-space: pre-wrap;@ to @text-diff@ class.
<pre><code class="diff">
diff --git a/public/stylesheets/application.css b/public/stylesheets/application.css
index c680fac92..e5224dca5 100644
--- a/public/stylesheets/application.css
+++ b/public/stylesheets/application.css
@@ -1073,6 +1073,7 @@ button.tab-left.disabled, button.tab-right.disabled {
background-color:#f6f6f6;
color:#505050;
border: 1px solid #e4e4e4;
+ white-space: pre-wrap;
}
/***** Wiki *****/
</code></pre>
Please see the following screenshots. Without @white-space: pre-wrap;@, you cannot see the whole content of long lines.
*Without @pre-wrap@:*
!{width: 900px; border: 1px solid #ccc;}.without-pre-wrap@2x.png!
*With @pre-wrap@:*
!{width: 900px; border: 1px solid #ccc;}.with-pre-wrap@2x.png!
--------------------------------------------------------------------------------
Committed, thanks.
--------------------------------------------------------------------------------