Vote #72315: MailHandler does not match assignee name with spaces - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #72315

完了

MailHandler does not match assignee name with spaces

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Email receiving_29

対象バージョン:

2.1.0_47

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/11552

category_id:

version_id:

issue_org_id:

11552

author_id:

60605

assigned_to_id:

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

We are working with the imap email ticket creation. It basically works except when the name has a - in it. Example would be First name = "IS -" and Last name = "Operations". If the First name is IS and the Last name = "Operations", the email processes fine. I saw while Googling around that I could use the Login instead which is isoperations. Tried that and it fails.

We are on version 1.4.1.stable.9612(MySql).
Our mail client is Exchange.

journals

Confirmed, this test fails when the user has a dash in their first name.

However assigning to the user "dashtest" works fine (the user's log in name).
--------------------------------------------------------------------------------
William Roush wrote:
> Confirmed, this test fails when the user has a dash in their first name.
>
> However assigning to the user "dashtest" works fine (the user's log in name).

Actually let me correct myself, the problem is that there is a space in the first name, I think Redmine is splitting on that space, and fails to look up the user.

Setting the name to "IS- Operations" works fine.

So I think it's doing first name "IS", last name "- Operations".
--------------------------------------------------------------------------------
> I think Redmine is splitting on that space, and fails to look up the user

You're perfectly right.
--------------------------------------------------------------------------------
Alright, here is a patch that adds a test that replicates the issue and a fix (Redmine 2.0 default branch).

I added the last combined check as a last-ditch check (re-iteration), I'm a bit worried about catching other names by accident so I only want to grab it if all other name look-ups fail first.

Of course the devs can move that somewhere else if they think that isn't a problem.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Thank you, that patch did fix it. The email works now with IS - Operations. Have a great day and thank you for the very quick fix!!
--------------------------------------------------------------------------------
Edit: sorry, scratch that, I had a filter issue.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Fixed in r10236 with a slightly different approach, thanks for pointing this out.
--------------------------------------------------------------------------------