Vote #72407: Avoid the use of tag("...", "...", true) in layout - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #72407

完了

Avoid the use of tag("...", "...", true) in layout

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Code cleanup/refactoring_30

対象バージョン:

2.1.0_47

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/11704

category_id:

version_id:

issue_org_id:

11704

author_id:

1188

assigned_to_id:

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

Here's a very simplified version of Redmine base layout :





  

    <%= tag('div', {:id => 'main', :class => (sidebar_content? ? '' : 'nosidebar')}, true) %>

      

        <%= yield :sidebar %>

      


      

        <%= yield %>

There's a "tag" helper, processed with ERB, to display "div#main", and it's closed with standard html in the end.

It could be considered as bad practice, but the main problem is that you cannot parse the layout correctly before it's fully processed by ERB. Hence gems that hook in the rendering process don't work correctly for the layout partial. It's the case of @deface@ (https://github.com/railsdog/deface) for instance, a gem I use these days so that I don't need 50 more view hooks in core.

1st solution : use inline erb just for the class

i.e. replace the tag line with :



  

        <%= yield :sidebar %>

      


      

        <%= yield %>

      


    <% end %>

I understand this isn't a problem for redmine core for now, but such a change would ease plugin development a lot and avoid overriding the layout/base partial.

Any thought on this is welcome.

journals

--------------------------------------------------------------------------------
Solution 1 committed in r10237.
--------------------------------------------------------------------------------
Thanks a lot :)
--------------------------------------------------------------------------------