プロジェクト

全般

プロフィール

Vote #72516

完了

Git and Mercurial diff displays deleted files as /dev/null

Admin Redmine さんが4年以上前に追加. 4年以上前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
SCM_3
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
3
version_id:
56
issue_org_id:
11868
author_id:
63416
assigned_to_id:
1
comments:
6
status_id:
5
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

It's the same bug reported here with ChiliProject: https://www.chiliproject.org/issues/589

Basically, in the diff view of git commits, deleted files show up as changes to the file @/dev/null@.

I'm using the Bitnami Redmine Stack, version 2.0.3-1. @Administration > Information@ shows:

Environment:
  Redmine version                          2.0.3.stable
  Ruby version                             1.8.7 (x86_64-linux)
  Rails version                            3.2.6
  Environment                              production
  Database adapter                         MySQL

journals

--------------------------------------------------------------------------------
What would be the expected behaviour?
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> What would be the expected behaviour?

To show the original file names, with some indication that the files are no longer there.

An example of reasonable behavior can be seen "here":https://github.com/hanjos/gameoflife-xna/commit/acd4184f77a599d9c8303b82dcf506fcbd8ee4df: in this commit, the files Events.cs and Utilities.cs no longer exist. When one clicks in *Show Diff Stats*, there is an icon showing that those files were removed.

*P.S.* Optionally, I wouldn't even show their contents too (my diff got truncated here, since some of the removed files were quite long...), but that's an extra :)
--------------------------------------------------------------------------------
Humberto Anjos wrote:
> To show the original file names, with some indication that the files are no longer there.
>
> An example of reasonable behavior can be seen "here":https://github.com/hanjos/gameoflife-xna/commit/acd4184f77a599d9c8303b82dcf506fcbd8ee4df: in this commit, the files Events.cs and Utilities.cs no longer exist. When one clicks in *Show Diff Stats*, there is an icon showing that those files were removed.

Fixed in r10424. The indication that the file was deleted is displayed on the revision view.

> *P.S.* Optionally, I wouldn't even show their contents too (my diff got truncated here, since some of the removed files were quite long...), but that's an extra :)

Not sure that this behaviour is desirable to everyone, maybe a seperate feature request.
--------------------------------------------------------------------------------
Oh, and don't forget to clear your cache if you upgrade (diff rendering is cached).
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0