Vote #72635
完了User#allowed_to? should return true or false
開始日:
2022/05/09
期日:
進捗率:
0%
予定工数:
Redmineorg_URL:
category_id:
30
version_id:
56
issue_org_id:
12078
author_id:
4
assigned_to_id:
1
comments:
2
status_id:
5
tracker_id:
3
plus1:
0
affected_version:
closed_on:
affected_version_id:
説明
The attached patch fixes a minor bug in User.allowed_to?
Specifically, that method should return a boolean, but it actually sometimes returns a Role instead. This is because .detect is used when really .any? should be used.
I am not aware of this causing any serious issues, but I noticed this during debugging and was greatly confused when allowed_to? suddenly returned a Role ;).
journals
--------------------------------------------------------------------------------
Committed in r10614. Another change was required so that @User#allowed_to?@ return true or false and tests were updated.
--------------------------------------------------------------------------------
Admin Redmine さんが約4年前に更新
- カテゴリ を Code cleanup/refactoring_30 にセット
- 対象バージョン を 2.2.0_56 にセット
いいね!0