Vote #72867
完了Macros.rb extract_macro_options should use lazy search
0%
説明
I am unsure if the design was intended to be greedy, however for my macro I needed a lazy search since it took in a query string like: query=?show_issues=1&show_news=1&show_documents=1&show_files=1&show_wiki_edits=1. The current method matches "query=?show_issues=1&show_news=1&show_documents=1&show_files=1&show_wiki_edits" : "1". When I look for options[:query] it returns nil. By using a lazy search, I get the intended result: "query" : "?show_issues=1&show_news=1&show_documents=1&show_files=1&show_wiki_edits=1"
Perhaps we should be able to specify if greedy or lazy?
I have attached my "quite simple" patch.
journals
Fixed and tests added in r10885, thanks.
--------------------------------------------------------------------------------
Merged in 2.1-stable.
--------------------------------------------------------------------------------