Vote #72898
完了Use lambda in model scopes
0%
説明
Yesterday I had to monkey-patch "Group" in a plugin, and it turned out to be really difficult because there's a scope defined in the Group class which doesn't use lambda. In this case, the scope is evaluated directly, which fails with "Could not find table users" for instance if you're in a "db:migrate" phase and your database is empty.
Hence I propose moving all scopes to their lambda form so that these difficulties disappear for plugin development.
One more thing, using scopes without lambda (or a call-able) will be deprecated in Rails 4 and probably removed in Rails 4.1 (see "this commit":https://github.com/rails/rails/commit/0a12a5f8169685915cbb7bf4d0a7bb482f7f2fd2).
Let me know what you think. If you're OK with this change I can take care of verifying all models, running tests and making the change everywhere...
journals
If you want to see what's involved, here are the two commits on my plugin : "one":https://github.com/jbbarth/redmine_organizations/commit/64a3bd7f1559354a11d7231a850a6cedab1742af, "two":https://github.com/jbbarth/redmine_organizations/commit/a7d19ed4e09df6c96ecb317593c0a97a650d3bec (but please don't start me on the bad idea of monkey patching core classes, that's all I have now to accomplish this kind of change...)
--------------------------------------------------------------------------------
Looks ok to me, should be marked as a deprecated usage in RoR, too bad it is not?
--------------------------------------------------------------------------------
Agreed.
--------------------------------------------------------------------------------
Done in r10949. I left scopes in the same form they used before (some use Arel syntax, some use the rails 2 hash syntax) but I might dig into that later.
--------------------------------------------------------------------------------
Jean-Baptiste Barth wrote:
> Done in r10949. I left scopes in the same form they used before (some use Arel syntax, some use the rails 2 hash syntax) but I might dig into that later.
Thanks, scopes now use Arel BTW (r10950).
--------------------------------------------------------------------------------