Vote #73229
完了Wiki link syntax commit:repo_a:abcd doesn't work
0%
説明
The wiki syntax commit:repo_a used to link hash-named changesets doesn't work if repo identifier has underscore symbol.
Maybe in this code https://github.com/redmine/redmine/blob/master/app/helpers/application_helper.rb#L751 used wrong regular expression.
when 'commit', 'source', 'export'
if project
repository = nil
if name =~ %r{^(([a-z0-9\-]+)\|)(.+)$}
repo_prefix, repo_identifier, name = $1, $2, $3
repository = project.repositories.detect {|repo| repo.identifier == repo_identifier}
else
repository = project.repository
end
journals
Confirmed because I've observed the same behavior on my instance a week or two ago, but didn't dig into it.
--------------------------------------------------------------------------------
Fixed in r11281, the proposed path was not working.
Thanks for pointing this out.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
duplicates,Closed,13005,Can't link to changeset or source in repository that contains underscores