プロジェクト

全般

プロフィール

Vote #73229

完了

Wiki link syntax commit:repo_a:abcd doesn't work

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Text formatting_26
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
26
version_id:
68
issue_org_id:
12979
author_id:
62070
assigned_to_id:
1
comments:
3
status_id:
5
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

The wiki syntax commit:repo_a used to link hash-named changesets doesn't work if repo identifier has underscore symbol.

Maybe in this code https://github.com/redmine/redmine/blob/master/app/helpers/application_helper.rb#L751 used wrong regular expression.


          when 'commit', 'source', 'export'
            if project
              repository = nil
              if name =~ %r{^(([a-z0-9\-]+)\|)(.+)$}
                repo_prefix, repo_identifier, name = $1, $2, $3
                repository = project.repositories.detect {|repo| repo.identifier == repo_identifier}
              else
                repository = project.repository
              end

journals

Confirmed because I've observed the same behavior on my instance a week or two ago, but didn't dig into it.

--------------------------------------------------------------------------------
Fixed in r11281, the proposed path was not working.
Thanks for pointing this out.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------


related_issues

duplicates,Closed,13005,Can't link to changeset or source in repository that contains underscores

Admin Redmine さんが約4年前に更新

  • カテゴリText formatting_26 にセット
  • 対象バージョン2.2.3_68 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0