--------------------------------------------------------------------------------
That would be really useful functionality because it will allow us to use redmine wiki as project documentation source. Especially with redmine_pdf_documents plug-in available.
--------------------------------------------------------------------------------
But redmine_pdf_documents doesn't work in 2.x
--------------------------------------------------------------------------------
Yes the 2.x branach is
https://github.com/klausmeyer/redmine_pdf_documents/commit/3b7e464098484d0af7e61583adbbd6c8dac276ac
--------------------------------------------------------------------------------
Thanks, README is misleading becuase is read there is no redmine 2.x port
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
The "redmine_pdf_wiki":https://github.com/amartel/redmine_pdf_wiki plugin uses wkhtml2pdf to export pdf and promises to resolve macros.
A big disadavantge is that it's only runny on passenger.

--------------------------------------------------------------------------------
_#14412 - Wiki > Textile text with hidden part not correctly exported to pdf_ should be listed in the related issues
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
I think I have found a way to call macros when a pdf export is requested.

The function responsible for converting Redmine's textile to html in the pdf exportation class is @formatted_text@. This function then calls the following function to convert the text from textile to html:<pre> Redmine::WikiFormatting.to_html(Setting.text_formatting, text)</pre>

I noticed that macros were not processed when the pdf export request was issued. Knowing that both the pdf parser and the browser view were rendered based on html, and that the browser was correctly rendering the _hello world_ macro, it looked like different code paths were being followed. So I looked at the rendering of the View and found a method called @textilizable@. This method also converted the textile data into html, but did a bit more work, including processing the macros. Contained in it is also the @Redmine::WikiFormatting.to_html@ method.

The problem of macros not always translating well to other usages, besides in a browser, will be dealt later.

Logically the only change to be made was to change @WikiFormatting.to_html@ to @textilizable@ and that is what I have done. I had some problems including the right libraries and when I was out of ideas why the errors were so strange, I looked for how @textilizable@ was being used in the unit tests. Making the appropriate changes made everything work with very few changes.

To apply the patch (Redmine 2.3.2) simply type:
<pre>patch /path/to/redmine-2.3.2/lib/redmine/export/pdf.rb /path/to/pdf_macro.patch</pre>

Hope this helps.

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Note-11 patch is not unified diff.
This is converted patch.
--------------------------------------------------------------------------------
Patch from Note-12 causes error 500 on issue and Wiki PDF export (Redmine 2.3.1 and Redmine 2.3.3). Logs:

* Issue export
<pre>
NoMethodError (undefined method `truncate' for #<Redmine::Export::PDF::ITCPDF:0xbfbe9f0>):
app/helpers/application_helper.rb:697:in `block in parse_redmine_links'
app/helpers/application_helper.rb:666:in `gsub!'
app/helpers/application_helper.rb:666:in `parse_redmine_links'
app/helpers/application_helper.rb:513:in `block (2 levels) in textilizable'
app/helpers/application_helper.rb:512:in `each'
app/helpers/application_helper.rb:512:in `block in textilizable'
app/helpers/application_helper.rb:533:in `parse_non_pre_blocks'
app/helpers/application_helper.rb:511:in `textilizable'
lib/redmine/export/pdf.rb:118:in `formatted_text'
lib/redmine/export/pdf.rb:144:in `RDMwriteHTMLCell'
lib/redmine/export/pdf.rb:668:in `block in issue_to_pdf'
lib/redmine/export/pdf.rb:660:in `issue_to_pdf'
app/controllers/issues_controller.rb:124:in `block (2 levels) in show'
app/controllers/issues_controller.rb:116:in `show'
</pre>
* Wiki export
<pre>
NoMethodError (undefined method `strip_tags' for #<Redmine::Export::PDF::ITCPDF:0xcaf7254>):
app/helpers/application_helper.rb:821:in `block in parse_headings'
app/helpers/application_helper.rb:819:in `gsub!'
app/helpers/application_helper.rb:819:in `parse_headings'
app/helpers/application_helper.rb:516:in `textilizable'
lib/redmine/export/pdf.rb:118:in `formatted_text'
lib/redmine/export/pdf.rb:144:in `RDMwriteHTMLCell'
lib/redmine/export/pdf.rb:769:in `write_wiki_page'
lib/redmine/export/pdf.rb:749:in `wiki_page_to_pdf'
app/controllers/wiki_controller.rb:83:in `show'
</pre>
--------------------------------------------------------------------------------
Yes Yurii I found that problem and much more. it turned out that it was not straight forward. I have made significant progress to enable the PDF rendering to use @textilizable@ but it is not there yet(wiki links are not parsed and some internal errors are still not solved) if you are in a hurry I can drop here the in progress patch, maybe you could finish it. I am sorry I have not given the follow up but I have been very busy.
--------------------------------------------------------------------------------
Here goes the patch, as mentioned in my note before. Wiki links are not working and sometimes unescaped quoted also don't work. I will write about it further when I have time.

I also hope that now the patch is in the correct format.
--------------------------------------------------------------------------------
After some investigation I concluded that the problem with the crashes was due to @text.html_safe@ in the @textilizable@ method.
<pre><code class="ruby">
if @parsed_headings.any?
replace_toc(text, @parsed_headings)
end

text.html_safe

end
</code></pre>
For some reason the @CGI.unescapeHTML@ crashes when the string coming out of @textilizable@ is html safe and has quotes. It is not possible remove the @html_safe@ method in @textilizable@ because it would break most of the code relying in it. I have researched "html_safe method":http://makandracards.com/makandra/2579-everything-you-know-about-html_safe-is-wrong and found that the way it is implemented in @textilizable@ is dubious because there is user input being considered safe. I am not sure of additional security considerations, as I have tried injecting Javascript without success.

I found that the problem described above (@CGI.unescapeHTML@ not failing) is really weird, because if I apply @html_safe@ to the text and then perform a "cast" to force the "SafeBuffer":http://api.rubyonrails.org/classes/ActiveSupport/SafeBuffer.html no error is triggered. On the other hand, even when calling @CGI.unescapeHTML@ on an object returned by @to_s@ method, an error is triggered. It should be noted that the @to_s@ method simply returns self, so it is maybe expected that it's calling is redundant, and obviously would trigger the error just as a normal @SafeBuffer@ would.

The solution I found was to keep everything unchanged in @textilizable@ but performing a "hard string cast, string interpolation":http://stackoverflow.com/questions/15654676/how-to-convert-activesupportsafebuffer-to-string in the @formatted_text(text)@ method in "pdf.rb":http://www.redmine.org/projects/redmine/repository/entry/branches/2.3-stable/lib/redmine/export/pdf.rb

Finally I was able to reproduce and definitely confirm the error in the Rails console:
<pre><code class="ruby">CGI.unescapeHTML('The experimental macro Hello Latex[&amp;quot;\&amp;quot;sdsd\&amp;quot;&amp;quot;'.html_safe)</code></pre>

I will now report it to the "Rails mailing list":https://github.com/rails/rails/issues/12672 to hear their opinion.

The last problem standing is the links to the Wikis embedded in the pdf. I don't know yet why they are not working but I will play with the Rails console to expedite the resolution of the problem. Afterwards I believe a patch is ready, and the tests should be generated.
--------------------------------------------------------------------------------
Hi Paulo, is there any progress with your patch?
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
https://github.com/redmine/redmine/pull/48

<pre><code class="diff">
diff --git a/lib/redmine/export/pdf.rb b/lib/redmine/export/pdf.rb
index 00c6d13..67b0c8f 100644
--- a/lib/redmine/export/pdf.rb
+++ b/lib/redmine/export/pdf.rb
@@ -62,7 +62,9 @@ def formatted_text(text)
html = Redmine::WikiFormatting.to_html(Setting.text_formatting, text)
# Strip {{toc}} tags
html.gsub!(/<p>\{\{([<>]?)toc\}\}<\/p>/i, '')
- html
+ # Strip {{collapse()}} tags
+ html.gsub!(/\{\{collapse\((.*)?\)([^}]*)?\}\}/,'\1 \2')
+ html
end

def RDMCell(w ,h=0, txt='', border=0, ln=0, align='', fill=0, link='')
</class></pre>
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
Please testing include macro, the bug have not been fixed, I am using 2.6.0 stable version.
--------------------------------------------------------------------------------
Fixed in r13944, macros are now processed in the PDF export, as well as Redmine and wiki links.
--------------------------------------------------------------------------------

relates,New,11697,Problem with Wiki export to PDF / HTML / TXT — 'include' does not includes
relates,Closed,10689,PDF export prints brackets on wiki links
relates,Closed,9783,PDF Export ignores Child pages
relates,New,4992,Add printer friendly version of pages
relates,Reopened,550,Function to export whole wiki
relates,New,14412,Wiki > Textile text with hidden part not correctly exported to pdf
duplicates,Closed,12964,Macros should be rendered to PDF
duplicates,Closed,17970,Wiki PDF export doesn't render macros
duplicates,Closed,18748,exporting wiki with child page not work correctly