Vote #73322
完了New setting to include the status changes in issue mail notifications subject
0%
説明
Note: I searched but could find how to re-open an issue at #603. So I'm creating this new one.
Ideally, the subject would just contain:
[the project name, the tracker, the issue #], -status- and the subject of the issue.
No "status". This is useful because it allows email clients to thread all emails relating to a single issue together. "status" is already included in the email notification body so it's a duplicate any way.
Current subject line don't work with clients like Gmail. Reply from Gmail: "A conversation will break off into a new thread if the subject line of the conversation is changed" Source: http://support.google.com/mail/bin/answer.py?hl=en&answer=5900 The subject line change because the "status" change.
I would be happy to contribute testing :) Any volunteer for a patch?
journals
IIRC it's the same with Lotus notes / Domino...
--------------------------------------------------------------------------------
vote for this.
MS Outlook grouping also doesn't work with different subjects.
--------------------------------------------------------------------------------
Just for a reference: #1401 does not work for gmail as of now.
For temporary monkey-patching, so that the mail subject does NOT contain status names, one can modify the 48th and 69th line of "app/models/mailer.rb" as follows:
<pre><code class="diff">
@@ -48,1 +48,1 @@
- :subject => "[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}] (#{issue.status.name}) #{issue.subject}"
+ :subject => "[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}] #{issue.subject}"
@@ -69,1 +69,0 @@
- s << "(#{issue.status.name}) " if journal.new_value_for('status_id')
</code></pre>
I think it would be great if this behaviour can be configured in the application settings, just as different ways of displaying user names (USER_FORMATS in app/models/user.rb).
Hope I could work on this patch when I get time later...
--------------------------------------------------------------------------------
This is very close to #3660. Probably it's better to implement #3660 and fix this in one go.
--------------------------------------------------------------------------------
As for emails grouping in gmail, I found this blog post useful:
http://www.sensefulsolutions.com/2010/08/how-does-email-threading-work-in-gmail.html
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I disagree Peter Volkov; this is a longstanding usability issue; and if the fix is simply to remove a field from the email template that should not be blocked on a further enhancement.
If the maintainers agree this is reasonable I'll try to prepare a patch.
--------------------------------------------------------------------------------
Gmail is one of the most used email clients and I think it should be very nice to support email threading. The rule is simple, the subject of the email must be the same.
Go Maeda, do you think that we should do this configurable (ex: Show issue status in email notifications for issues) or we should just remove the status from the subject? IMO, I never found the status information from the subject useful.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> Go Maeda, do you think that we should do this configurable (ex: Show issue status in email notifications for issues) or we should just remove the status from the subject? IMO, I never found the status information from the subject useful.
I prefer making the subject line configurable rather than simply removing the status. The information that the status has been changed is useful for me.
I will try the patch in #17096#note-19 on my environment and check if the threading issue will be resolved.
--------------------------------------------------------------------------------
Go MAEDA wrote:
> I prefer making the subject line configurable rather than simply removing the status. The information that the status has been changed is useful for me.
Thanks, I’ll prepare a patch.
> I will try the patch in #17096#note-19 on my environment and check if the threading issue will be resolved.
For Gmail won’t work because the rule for threading uses only the subject, but I’m curios if it’ll fix the problem on Exchange/Office365.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> For Gmail won’t work because the rule for threading uses only the subject, but I’m curios if it’ll fix the problem on Exchange/Office365.
I have just confirmed that patch #17096#note-19 has no effect on Gmail. Unfortunately, I cannot test Exchange/Office365.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> Go MAEDA wrote:
> > I prefer making the subject line configurable rather than simply removing the status. The information that the status has been changed is useful for me.
> Thanks, I’ll prepare a patch.
>
Attached the patch that adds a new setting to include the status changes in issue mail notifications subject.
The setting is useful to control the grouping of mails on some mail clients (Gmail for example).
By default, the setting is enabled to not change the current behaviour.
!{border: 1px solid grey; width: 70%;}new_setting.png!
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I can confirm that applying the patch on the current trunk fixes the thread issues on both major mail platforms:
1. Office 365
!{border: 1px solid grey; width: 70%;}.office365.png!
2. Gmail
!{border: 1px solid grey; width: 70%;}.gmail.png!
Most probably, for Office 365 is not only the proposed patch, but also a fix available only on the current trunk.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Marius, thank you for the patch. The patch works fine but I have one suggestion.
How about storing the setting value as an Array instead of an integer value, like Setting.notified_events? It is useful when we make the subject line more configurable in the future. For example, we may add a setting to show/hide a project name or tracker name.
--------------------------------------------------------------------------------
Go MAEDA wrote:
> How about storing the setting value as an Array instead of an integer value, like Setting.notified_events? It is useful when we make the subject line more configurable in the future. For example, we may add a setting to show/hide a project name or tracker name.
I prefer to do a migration at that moment (it won't be a big deal) because we don't know (or at least me) how this feature will develop in the future. I see at least 3 options :) But if you really want to store it as Array, I can change my patch.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> I prefer to do a migration at that moment (it won't be a big deal) because we don't know (or at least me) how this feature will develop in the future.
It makes sense.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Committed the patch. Thank you for improving Redmine.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,New,3660,Configurable subject of notification email for issue_add/issue_edit
relates,Closed,17096,Issue emails cannot be threaded by some mailers due to inconsistent Message-ID and References field
relates,New,13658,include "In-Reply-To" field to aid email threading for some clients
relates,Closed,31065,Fix tests that has incorrect verification target
duplicates,Closed,13083,Ticket status on email subject
copied_to,Closed,603,Don't include new status for issues in email subject