Vote #73700
完了Parent issue column includes issue subject (making issue list unworkable wide)
0%
説明
Hi. There is a report for the new bug I've just found.
Since redmine 2.3.0, the parent issue field is being displayed too long with the issue's title in the list view.
This disturbs the list narrowing other columns as figure below, especially when the issues have long titles.
!too-long-parent-issue.png!
I found r10972 (#1766) is responsible for this behavior; it seems that this is just a mistake rather than intended.
This is a workaround patch I've tried:
--- app/helpers/queries_helper.rb (revision 11695)
+++ app/helpers/queries_helper.rb (working copy)
@@ -100,7 +100,7 @@ module QueriesHelper
when 'FalseClass'
l(:general_text_No)
when 'Issue'
- value.visible? ? link_to_issue(value) : "##{value.id}"
+ value.visible? ? link_to_issue(value, :subject => false) : "##{value.id}"
when 'IssueRelation'
other = value.other_issue(issue)
content_tag('span',
Thanks.
journals
Any feedback on this?
--------------------------------------------------------------------------------
+ 1
--------------------------------------------------------------------------------
+1, This makes the list practically unusable.
I've taken parent task out of my default columns until there is a fix.
--------------------------------------------------------------------------------
Wish 2.3.3 maintenance release would include this.
--------------------------------------------------------------------------------
+1, Wish 2.3.4 maintenance release would include this.
--------------------------------------------------------------------------------
Jongwook Choi wrote:
> Since redmine 2.3.0, the parent issue field is being displayed *too long with the issue's title* in the list view.
> This disturbs the list narrowing other columns as figure below, especially when the issues have long titles.
> [...]
> I found r10972 (#1766) is responsible for this behavior; it seems that this is just a mistake rather than intended.
I can confirm the issue on current trunk. It is indeed introduced in r10972. Though, it isn't a mistake for sure. It is an intended change that is required to render the value for the issue column on the spent time reports correctly.
> This is a workaround patch I've tried:
That patch breaks the issue column on the spent time reports.
Here follows a quick patch that restores the previous markup of the parent task column values on the issue list (without subject) and maintains (and restores) markup of the issue column values on the spent time reports (with subject truncated to 50 chars[1]) without breaking parts of the core[2]:
<pre><code class="diff">
Index: app/helpers/queries_helper.rb
===================================================================
--- app/helpers/queries_helper.rb (revision 12224)
+++ app/helpers/queries_helper.rb (working copy)
@@ -124,7 +124,12 @@
when 'FalseClass'
l(:general_text_No)
when 'Issue'
- value.visible? ? link_to_issue(value) : "##{value.id}"
+ case @query.class.name
+ when 'IssueQuery'
+ value.visible? ? link_to_issue(value, :subject => false) : "##{value.id}"
+ when 'TimeEntryQuery'
+ value.visible? ? link_to_issue(value, :truncate => 50) : "##{value.id}"
+ end
when 'IssueRelation'
other = value.other_issue(issue)
content_tag('span',
</code></pre>
fn1. although it might be a good idea to keep the unlimited description here like introduced in r10972.
fn2. although, I am not sure if this change doesn't break the existing test suite.
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
I´m looking for a fix to remove the subject from the column parent task in Redmine 2.5.
Is there a possibility to fix this in any file?
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Try #16437 patch.
--------------------------------------------------------------------------------
Thanks. This is better than bevor.
I hope in the next minor Version the there is a possibility to remove the name or to configure the content of the column.
--------------------------------------------------------------------------------
+1, but I would be in favor to solve this issue via CSS. The column "Parent Task" does not get wrapped due to this CSS property:
_/stylesheets/application.css: 152_
<pre>
tr.issue { text-align: center; white-space: nowrap; }
</pre>
This would actually mean, that every column will not be wrapped if the column gets to wide, but the next statement makes some exceptions:
_/stylesheets/application.css: 153_
<pre>
tr.issue td.subject, tr.issue td.category, td.assigned_to, tr.issue td.string, tr.issue td.text, tr.issue td.relations { white-space: normal; }
</pre>
I am in favor to add the parent column to this list of exceptions.
--------------------------------------------------------------------------------
Related to #13608 and #16227.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
René Carolus wrote:
> I´m looking for a fix to remove the subject from the column parent task in Redmine 2.5.
> Is there a possibility to fix this in any file?
Second that; I, too, am looking for a solution in RedMine 2.5, but the patched code parts are no longer part of query_helper.rb, as it seems.
Could someone _please_ provide some hint? Thanks!
--------------------------------------------------------------------------------
Fixed in r13556, the parent column contains tracker and issue id only as before.
--------------------------------------------------------------------------------
Merged.
--------------------------------------------------------------------------------
I have just updated to 2.6.2 and this broke a lot for us...
Seeing only parent issue number makes the column useless because we do not know what the parent is about :/ often parent subject contains general information (e.g. test A) and then more details in subtasks (e.g. prepare setup, make report, etc.), now I see only few tasks like prepare setup with no information what the setup is for :/
Wasn't better fix for this provided in #19120 and in note 13? Or maybe an option in settings?
I have added another issue #19371 to track this separately.
--------------------------------------------------------------------------------
+1 for config option.
Same here at my company. Actually, since we switched to Redmine, we always saw the parents subject, so when it now went away, we first believed it was a bug. I see the majority of users prefers the form without the subject. So a config option would be great.
--------------------------------------------------------------------------------
+1, it would be great to give an option to show the subject.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,Closed,16437,Parent task is not wrapped in the Issues list
relates,Closed,13608,Parent column in CSV export should include issue id only
relates,Closed,19371,Add a new query column for the parent task subject
duplicates,Closed,16227,Father task info displayed in issue tooooooooo long