Vote #73719
完了Back-button on diff page is not working when I'm directed from email
0%
説明
+Situation:+
I get an email from Redmine with a diff-link to the changed description of an issue. I click on that link in my email to get informed about changed details.
+Problem:+
When I click now on the back-link on the diff page, nothing happends.
+Reason:+
The back-link tries to get the page I've been before (history.back()), but there not such a page.
I fixed this problem with a patch.
journals
Woudn't you agree to apply this patch? Otherwise I can't go from a diff page to its issue page.
--------------------------------------------------------------------------------
Committed in trunk r11893, thanks.
--------------------------------------------------------------------------------
The problem is, that browsers handle <code>history.length</code> differently: http://www.w3schools.com/jsref/prop_his_length.asp
I would suggest the following code, tested on Firefox, IE and Opera:
<pre>
<code>history.back(); return (document.referrer=="");</code>
</pre>or
<pre>
<code>if (document.referrer!="") {history.back(); return false;}</code>
</pre>
I tested it like this: <code>history.back(); alert((document.referrer=="")); return (document.referrer=="");</code>
--------------------------------------------------------------------------------
Committed in trunk r11900, thanks.
--------------------------------------------------------------------------------