Vote #73736
未完了Collapse doesn't work with section edit link
0%
説明
Collapsed with @collapse@ macro sections don't have an edit link. More than this, all following edit links don't work properly, because service-side numeration take into account all sections, even collapsed, but client-side doesn't.
journals
I can't reproduce the “more than this” part.
Considering the first part. Here is what we have in @app/helpers/application_helper.rb (line 527)@:
<pre><code class="ruby">
macros = catch_macros(text)
#...
parse_sections(text, project, obj, attr, only_path, options)
</code></pre>
@catch_macros@ is a mutator, all instances of @{{ macro ... }}@ in @text@ are placed with @{{macro(N)}}@, so there is no chance @parse_sections@ can see @<h1>...@ inside. I don't know whether it was made on purpose or not, but I believe you can *reject this issue*.
--------------------------------------------------------------------------------
It happens to me as well (the part before the "more than this").
Is there a reason you suggested rejecting this issue?
--------------------------------------------------------------------------------
It's not exactly a bug, it looks more like a feature.
--------------------------------------------------------------------------------
Maybe an unavoidable behavior, but a feature?
If there are sections inside a collapser, why shouldn't the user be able to edit them?
I think it's best if the formatter treats the collapse as a section. That way you can edit the entire collapse, or any section within it, same as you would any section.
--------------------------------------------------------------------------------
Yeah, it would be perfect and natural, but unfortunately macros are just not made this way.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,New,26974,Collapse macro conflicts with header section edit buttons