プロジェクト

全般

プロフィール

Vote #73772

完了

Show warning if CSV-Export exceeds limit

Admin Redmine さんが4年以上前に追加. 4年以上前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Issues_2
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
2
version_id:
75
issue_org_id:
13774
author_id:
61731
assigned_to_id:
1
comments:
6
status_id:
5
tracker_id:
3
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

Hi there,

Filou Centrinov has reported a feature request in #13770. This patch aims to fix this.

Best regards,
Daniel


journals

Three translation suggestions:
1st: EN: Export contains only %{export} of %{total} issues.
2nd: EN: Export contains only the first %{export} of %{total} issues.
3rd: EN: Export limit is {X}.

Also the pdf export needs a warning. I know, there is no dialog by default.
--------------------------------------------------------------------------------
I think like this it would be more simple and logical:
<pre>
<% if @issue_count > @csv_limit %>
<div class="flash warning">
<%= l(:warning_export_limit, :export => @csv_limit, :total => @issue_count) %>
</div>
<% end %>
</pre>
--------------------------------------------------------------------------------
Hi Filou,

your right the condition could be changed in this order. Well the result will be the same. :-)
I changed this in the patch.

In addition, I removed the .min. I added it in the first version (not uploaded here) to always display the count of the exported issues.

I changed the size of the modalbox and changed the translation to your suggestion nr. 1 in note 1.

If anyone has translations for this in his language, please provide them. I'll include them in the patch.

Best regards,
Daniel
--------------------------------------------------------------------------------
Any news on this? Is this patch okay?
--------------------------------------------------------------------------------
Seems ok at first sight, but needs a test or two so we won't break it inadvertently in a future release. I assign the issue to myself, I'll test it and write some tests tomorrow (except if you want to do so Daniel, would be great ;-))

Just one thing though, I'm always reluctant to add new locale keys (locale maintenance is a tiny nightmare). Isn't it possible to use the already existing @setting_issues_export_limit@ ?
--------------------------------------------------------------------------------
Feature added in r12663. I used the existing i18n string and added some tests.
--------------------------------------------------------------------------------


related_issues

relates,Closed,13770,Show warning, when exported issues exceed the limit

Admin Redmine さんが4年以上前に更新

  • カテゴリIssues_2 にセット
  • 対象バージョン2.5.0_75 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0