Vote #74288
完了Gantt, completed % truncated instead of rounded
0%
journals
Here is a patch
--------------------------------------------------------------------------------
+1 to the patch.
But English comments would be better. ;-)
--------------------------------------------------------------------------------
Sorry :-)
--------------------------------------------------------------------------------
Np. Looks better. :-)
--------------------------------------------------------------------------------
Any chance that this very simple patch could be integrated to the core ?
--------------------------------------------------------------------------------
This problem is not only pdf but also web form.
<pre><code class="diff">
diff --git a/app/views/issues/_attributes.html.erb b/app/views/issues/_attributes.html.erb
--- a/app/views/issues/_attributes.html.erb
+++ b/app/views/issues/_attributes.html.erb
@@ -63,7 +63,7 @@
<% end %>
<% if @issue.safe_attribute? 'estimated_hours' %>
-<p><%= f.text_field :estimated_hours, :size => 3, :disabled => !@issue.leaf?, :required => @issue.required_attribute?('estimated_hours') %> <%= l(:field_hours) %></p>
+<p><%= f.text_field :estimated_hours, :size => 10, :disabled => !@issue.leaf?, :required => @issue.required_attribute?('estimated_hours') %> <%= l(:field_hours) %></p>
<% end %>
<% if @issue.safe_attribute?('done_ratio') && @issue.leaf? && Issue.use_field_for_done_ratio? %>
</code></pre>
!view.png!
!edit.png!
--------------------------------------------------------------------------------
Hi Toshi,
You are talking about estimated_hours, do you mean that this is linked to done_ratio ?
The only place I have found this issue is in the Gantt, on the versions display percent is not truncated.
--------------------------------------------------------------------------------
Duplicated by #13442
--------------------------------------------------------------------------------
Jérôme BATAILLE wrote:
> Hi Toshi,
>
> You are talking about estimated_hours, do you mean that this is linked to done_ratio ?
> The only place I have found this issue is in the Gantt, on the versions display percent is not truncated.
Sorry, I confused with #12510#note-15.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
It is reasonable because issue form uses round.
source:tags/2.5.1/app/helpers/application_helper.rb#L1122
--------------------------------------------------------------------------------
Committed in trunk r13137, thanks.
--------------------------------------------------------------------------------
Thanks a lot ! this is Smile 13'th patch integrated into the core.
--------------------------------------------------------------------------------
related_issues
duplicates,Closed,13442,Gantt : rounding error for version completed percent