Vote #74305
完了Better block detection on my page
0%
説明
Hi there,
I'm not sure if this is really better, but in my eyes this looks a little bit better.
I checked this line: source:/trunk/app/controllers/my_controller.rb#L142
Replace:
unless %w(top left right).detect {|f| (@blocks[f] ||= []).include?(k)}
@block_options << [l("my.blocks.#{v}", :default => [v, v.to_s.humanize]), k.dasherize]
end
with:
unless @blocks.map{ |key, value| value}.flatten.include?(k)
@block_options << [l("my.blocks.#{v}", :default => [v, v.to_s.humanize]), k.dasherize]
end
This type don't need a list of defined areas (left,right,top) and could handle even more areas.
Best regards,
Daniel
journals
Hi Toshi,
maybe you have some time to take a look at this?
Best regards,
Daniel
--------------------------------------------------------------------------------
Patch committed in r12658, thanks. FYI I've replaced @.map{ |key, value| value}@ with a simple @.values@.
--------------------------------------------------------------------------------
Admin Redmine さんが約4年前に更新
- カテゴリ を Code cleanup/refactoring_30 にセット
- 対象バージョン を 2.5.0_75 にセット