プロジェクト

全般

プロフィール

Vote #74323

完了

Wrong done_ratio calculation for parent with subtask having estimated_hours=0

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Issues planning_40
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
40
version_id:
73
issue_org_id:
14798
author_id:
61731
assigned_to_id:
1
comments:
3
status_id:
5
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

Hi there,

this patch corrects a bug in the calculation of the done_ratio value in some edge case.

Ways to reproduce this bug:

  • Define a parent issue
  • Define two subissues on this parent issue
  • Set on one subissue estimated_hours to 0
  • Close subissue with no estimated_hours -> parent issue has done_ratio = 50%
  • Close subissue with estimated_hours set to zero value -> parent issue still has done_ratio = 50%

This patch solves this issue.

@Jean-Philippe: Maybe you or Toshi could take a look at this?

Best regards,
Daniel


journals

We also stumbled on this at "Planio":http://plan.io, the proposed diff fixes the problem, thanks!
--------------------------------------------------------------------------------
Patch committed with a test, thanks for pointing this out.
--------------------------------------------------------------------------------
Merged.
--------------------------------------------------------------------------------

Admin Redmine さんが約4年前に更新

  • カテゴリIssues planning_40 にセット
  • 対象バージョン2.3.3_73 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0