Vote #74480: Project authorization EnabledModule N+1 queries - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #74480

完了

Project authorization EnabledModule N+1 queries

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Code cleanup/refactoring_30

対象バージョン:

2.4.0_70

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/15058

category_id:

version_id:

issue_org_id:

15058

author_id:

87200

assigned_to_id:

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

There's a problem with project authorization that causes N+1 queries (one per project in @projects).

In ApplicationController#authorize redmine checks authorization on @project or @projects. This triggers the code in Project#allowed_permissions which calls @enabled_modules.pluck(:name)@.

The problem here is that pluck circumvents preloading, so no matter wether we do @@projects = Project.includes(:enabled_modules).where(conditions)@ in a controller, it will still trigger one extra query per project.

Given that the EnableModule model is tiny, this could be prevented by using @enabled_modules.map(&:name)@ instead.

journals

Fixed in r12228, @#pluck@ won't be called is the association is preloaded.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Nice solution, I didn't know about @loaded?@ until now.
--------------------------------------------------------------------------------