Vote #74501: Issue#update_nested_set_attributes comparing nil with empty string - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #74501

完了

Issue#update_nested_set_attributes comparing nil with empty string

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

低め

担当者:

カテゴリ:

Code cleanup/refactoring_30

対象バージョン:

2.4.0_70

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/15135

category_id:

version_id:

issue_org_id:

15135

author_id:

86283

assigned_to_id:

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

I had problem with slow issue update. Issue have ~20 subtasks and 1 related issue. Update on that task always ended with timeout error.
It's appears that Issue#update_nested_set_attributes (after_save hook) there is "comparision parent_issue_id != parent_id":http://www.redmine.org/projects/redmine/repository/entry/branches/2.3-stable/app/models/issue.rb#L1277.
In my case parent_issue_id was nil and parent_id empty string, it's leads to unnecessary code execution.
When I change:

elsif parent_issue_id != parent_id

elsif parent_issue_id.to_i != parent_id.to_i

update is now 4 times faster.

Ruby: 1.9.3-p429
Rails: 3.2.13
Redmine: 2.3.3

journals

I fixed the root cause in @parent_issue_id=@ rather than the comparaison and added a few tests to make sure that this code is called only when needed (r12226), thanks for pointing this out.
--------------------------------------------------------------------------------