Vote #74569
完了Improve usage of label "button_update"
0%
説明
Hi, today I discovered an improper german translation of @button_update@:
button_update: Bearbeiten
should better be
button_update: Aktualisieren
While the first has the meaning of "edit", the second corresponds to "update by applying my changes". Unfortunately, @button_update@ seems also to be used for editing issues:
$ grep -rn button_update app/
app/views/issues/_action_menu.html.erb:2:<%= link_to l(:button_update), edit_issue_path(@issue), :onclick => 'showAndScrollTo("update", "issue_notes"); return false;', :class => 'icon ico
n-edit', :accesskey => accesskey(:edit) if @issue.editable? %>
app/views/issues/show.html.erb:131:
<%= l(:button_update) %>¶
app/views/repositories/committers.html.erb:39:<%= submit_tag(l(:button_update)) %>
Therefore, I would suggest to change the translation and change @button_update@ to @button_edit@ for the first two occurrences. It is fine for the third, I think.
What do you think? Comments welcome!
journals
Well, another solution may also be to change @button_update@ to @button_save@ in @app/views/repositories/committers.html.erb:39@, but I think the other change may also be worth it.
--------------------------------------------------------------------------------
Changes done.
--------------------------------------------------------------------------------
Cool, thanks!
--------------------------------------------------------------------------------
And now we have a weird way to add a comment by the "Edit" button. I'm sure we will get used to it but it doesn't seem logical.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,Closed,7856,Change "Update" to "Update/Reply" on issue#show
relates,Closed,9033,German semantic translation mistake