プロジェクト

全般

プロフィール

編集 操作
リンクをコピー

Vote #74707

完了

Make favicon themeable

Admin Redmine さんが4年以上前に追加. 4年以上前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Themes_38
対象バージョン:
2.5.0_75
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
Redmineorg_URL:
https://www.redmine.org/issues/15689
category_id:
38
version_id:
75
issue_org_id:
15689
author_id:
3866
assigned_to_id:
1
comments:
7
status_id:
5
tracker_id:
3
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed] 
引用

説明

"Plan.io":https://plan.io had the case that we needed to be able to set the favicon according to the theme. We have developed a patch to be able to use a favicon from the @favicon@ directory in the theme directory (if more than one is available the @[].first@ will be used).

(Patch coming up as soon as I have an issue number)

journals

Here's the patch.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Could you add a test for this? See source:/trunk/test/integration/lib/redmine/themes_test.rb
--------------------------------------------------------------------------------
Sure, see the attached updated patch.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Patch committed in r12646 with slight changes:
* ruby 1.8 compatibility syntax
* use of @#assert_select@ instead of @#assert_tag@

Thanks.
--------------------------------------------------------------------------------
Thanks!
--------------------------------------------------------------------------------

編集 操作
リンクをコピー

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0

demo1.unofficial-redmine.org