Vote #74979: Relax rejections based on Auto-Submitted header - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #74979

完了

Relax rejections based on Auto-Submitted header

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Email receiving_29

対象バージョン:

2.6.0_81

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/16190

category_id:

version_id:

issue_org_id:

16190

author_id:

3866

assigned_to_id:

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

One of our ("Plan.io":https://plan.io) uses an email server to forward messages to a Redmine instance which inserts @Auto-Submitted: auto-forwarded@ headers to the forwarded emails. Those emails are then rejected because of source:/trunk/app/models/mail_handler.rb@12937#L69.

Putting the fact aside that this header is only part of an IETF draft and not of an RFC, and that even according to that draft it shouldn't be there, this header causes the forwarded emails to be reject. We propose changing the Regex to only match the undesirable values defined in "RFC3834":http://tools.ietf.org/search/rfc3834#section-5, i.e. @/^{auto-(replied|generated)/@.}

journals

And here is the patch.
--------------------------------------------------------------------------------
To cite from "RFC 3834":http://tools.ietf.org/search/rfc3834#section-5

> Recipients of messages containing an Auto-Submitted field with any keyword other than "no" MAY assume that the message was not manually submitted by a human.

Thus, although it may be correct to swallow this email, it makes it much harder for people using kind-of-broken mail servers (like Lotus Domino) which forcefully include the @Auto-Submitted: auto-forwarded@ header into all outgoing mails touched by their forwarding script.

In addition, given that forwarded mails generally are assumed to be valid, we could thus argue that the @auto-forwarded@ mails are not to be dropped.
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
Patch verified (and it's trivial anyway), can someone please merge this?

IMHO it's important that we merge such trivial patches right away and not let the contributor wait too long...
--------------------------------------------------------------------------------
Jan Niggemann (redmine.org team member) wrote:
> Patch verified (and it's trivial anyway), can someone please merge this?
>
> IMHO it's important that we merge such trivial patches right away and not let the contributor wait too long...

I tried the patch in redmine-2.4.5 and worked fine. i'm using Lotus Domino and now the messages are not rejected.

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Committed in trunk r13205, r13206 and r13207, thanks.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

related_issues

relates,Closed,11338,Exclude emails with auto-submitted => auto-generated
relates,Closed,15999,Ignoring out of office emails
relates,Needs feedback,20465,MailHandler: ignoring email with Auto-Submitted:auto-generated header