プロジェクト

全般

プロフィール

Vote #75162

完了

Markdown formatter should use the :no_intra_emphasis extension

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Text formatting_26
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
26
version_id:
84
issue_org_id:
16669
author_id:
99847
assigned_to_id:
1
comments:
3
status_id:
5
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
82
ステータス-->[Closed]

説明

I'm so excited to see Redmine supporting markdown with Redcarpet (#15520)! However, this is causing a lot of unintended emphasis rendering, e.g. at ruby-lang.org [1]. I think the :no_intra_emphasis extension should be enabled when creating the Redcarpet::Markdown formatter. From the Redcarpet docs [2]:

:no_intra_emphasis: do not parse emphasis inside of words.
Strings such as foo_bar_baz will not generate <em> tags.

The fix is just to add :no_intra_emphasis => true to Redmine::WikiFormatting::Markdown::Formatter#formatter

[1] https://bugs.ruby-lang.org/issues/9726, https://bugs.ruby-lang.org/issues/9724, https://bugs.ruby-lang.org/issues/9719, https://bugs.ruby-lang.org/issues/9683, https://bugs.ruby-lang.org/issues/9679 are just the 5 most recent.
[2] https://github.com/vmg/redcarpet#and-its-like-really-simple-to-use


journals

--------------------------------------------------------------------------------
Fixed in r13105.
--------------------------------------------------------------------------------
Merged.
--------------------------------------------------------------------------------

Admin Redmine さんが約4年前に更新

  • カテゴリText formatting_26 にセット
  • 対象バージョン2.5.2_84 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0