Vote #75199
完了Member#destroy triggers after_destroy callbacks twice
0%
説明
The callback 'after_destroy' for Member is called twice when deleting a member due to the following lines
https://github.com/redmine/redmine/blob/master/app/controllers/members_controller.rb:99
and
https://github.com/redmine/redmine/blob/master/app/models/member_role.rb:42
journals
https://github.com/redmine/redmine/blob/master/app/controllers/members_controller.rb
<pre>
def destroy
if request.delete? && @member.deletable?
@member.destroy
end
respond_to do |format|
format.html { redirect_to_settings_in_projects }
format.js
format.api {
if @member.destroyed?
render_api_ok
else
head :unprocessable_entity
end
}
end
end
</pre>
https://github.com/redmine/redmine/blob/master/app/models/member_role.rb
<pre>
def remove_member_if_empty
if member.roles.empty?
member.destroy
end
end
</pre>
--------------------------------------------------------------------------------
Fixed in r13140, thanks for pointing this out.
--------------------------------------------------------------------------------
Merged.
--------------------------------------------------------------------------------
Admin Redmine さんが約4年前に更新
- カテゴリ を Code cleanup/refactoring_30 にセット
- 対象バージョン を 2.5.2_84 にセット