Vote #75295
完了File upload broken on Chrome 36
0%
説明
On Fedora 20:
https://www.google.com/intl/en/chrome/browser/beta.html
$ LANG=C rpm -qi google-chrome-beta-36.0.1985.49-1.x86_64 Name : google-chrome-beta Version : 36.0.1985.49 Release : 1 Architecture: x86_64 Install Date: Wed Jun 11 13:27:12 2014 Group : Applications/Internet Size : 182695355 License : Multiple, see http://chrome.google.com/ Signature : DSA/SHA1, Wed Jun 4 10:07:36 2014, Key ID a040830f7fac5991 Source RPM : google-chrome-beta-36.0.1985.49-1.src.rpm Build Date : Wed Jun 4 09:59:53 2014 Build Host : precise64build1.chrome.corp.google.com Relocations : /opt Packager : Chrome Linux TeamVendor : Google Inc. URL : http://chrome.google.com/ Summary : Google Chrome Description : The web browser from Google Google Chrome is a browser that combines a minimal design with sophisticated technology to make the web faster, safer, and easier.
When "Choose Files" is clicked:
!fedora20-chrome-36.png!
journals
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
It's a beta, are you sure it's not a browser issue ?
--------------------------------------------------------------------------------
Etienne Massip wrote:
> It's a beta,
Yes.
But "37.0.2042.0 canary" has same problem.
http://www.chromium.org/getting-involved/download-chromium
> are you sure it's not a browser issue ?
No problem with following browser on my Windows 8.1
* Firefox 29.0.1
* Chrome 35.0.1916.153 m
* IE 11.0.9699.17107
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I can confirm this bug on 38.0.2066.5 canary too, and a Planio customer observed this issue on Chrome 36.0.1985.84 too.
I think this is a browser issue though as both browsers make 2 requests to @upload.js@ with 2 different @attachment_id@ (1 and 2 in my and the customers tests).
--------------------------------------------------------------------------------
Please find attached the proposed patch from one of my colleagues at "Planio":https://plan.io. This fixes the issue for us in Chrome 38.
It seems in Chrome 36 and following @$(inputEl).clone().val('');@ (source:trunk/public/javascripts/attachments.js@13182#L118) triggers the @onchange@ callback a second time, adding the callback later instead of inline with the element solves this issue.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I have confirmed this patch fixes in google-chrome-beta-36.0.1985.84-1 on Fedora 20.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
If this is a beta browser version issue, then why not fix browser instead??
--------------------------------------------------------------------------------
The issue is indeed in the js code, but as it is somewhat of a corner case it didn't create a problem until now.
Furthermore, following this logic you would need to remove all IE or other browser-specific hacks :-)
--------------------------------------------------------------------------------
Felix Schäfer wrote:
> Furthermore, following this logic you would need to remove all IE or other browser-specific hacks :-)
You don't get it, this fix is for a _beta_ version, this is nonsense if the bug is indeed in the browser and not in jq or ror.
Could we wait for the 36 release to make sure it affects it too before committing it, eventually report the issue to chrome project?
--------------------------------------------------------------------------------
Etienne Massip wrote:
> If this is a beta browser version issue, then why not fix browser instead??
Chrome 36, 37 and 38 have this problem.
Chrome and Chromium version policy is not clear.
I am afraid Chrome and Chromium team will refuse bug fix of Chrome 36.
Such as Rails team refused bug fix of Rails 3.2.
--------------------------------------------------------------------------------
What if it has already been fixed in 36 release?
--------------------------------------------------------------------------------
> Such as Rails team refused bug fix of Rails 3.2.
http://goo.gl/1G4olw
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I have created chromium ticket.
http://goo.gl/FjMZtS
--------------------------------------------------------------------------------
http://goo.gl/ReABLM
> It may be too late for Google Chrome 36.
--------------------------------------------------------------------------------
Chrome/Chromium version policy is not clear.
So, I committed trunk r13199, 2.5-stable r13201 and 2.4-stable r13203.
--------------------------------------------------------------------------------
Thanks!
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Chrome 36 is out and the regression hasn't been merged so it's buggy til 37 comes.
That would be great to add a comment to explain that this commit is due to regression and can be reverted when 37 is out.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Works for me.
Redmine: 2.5.1.stable
Google Chrome: 36.0.1985.125
Toshi MARUYAMA wrote:
> Chrome/Chromium version policy is not clear.
> So, I committed trunk r13199, 2.5-stable r13201 and 2.4-stable r13203.
--------------------------------------------------------------------------------
Rafał Lisowski wrote:
> Redmine: 2.5.1.stable
> Google Chrome: 36.0.1985.125
Not works for me.
--------------------------------------------------------------------------------
Gennady Grechin wrote:
> Rafał Lisowski wrote:
>
> > Redmine: 2.5.1.stable
> > Google Chrome: 36.0.1985.125
>
> Not works for me.
Because r13201 is in version:2.5.2, not in version:2.5.1.
version:2.5.2 includes version:2.4.6 fixes.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
The patch for 2.4 and 2.5 doesn't work in 2.3. Attached is the patch for 2.3. It modifies attachments.js to remove the onchange before cloning the input box, then it adds it to the cloned box afterwards.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Pierre Pretorius wrote:
> The patch for 2.4 and 2.5 doesn't work in 2.3. Attached is the patch for 2.3. It modifies attachments.js to remove the onchange before cloning the input box, then it adds it to the cloned box afterwards.
*Thank you very much Pierre*, your patch file for 2.3 solved the problem within my _2.3.4.stable.12746_.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Quick question.. on the 2.3 patch, does views/attachements/_form.html.erb need updated as well or just the javescript part?
--------------------------------------------------------------------------------
Cheyenne Wills wrote:
> Quick question.. on the 2.3 patch, does views/attachements/_form.html.erb need updated as well or just the javescript part?
I patched only the javascipt file with the command:
<pre>
patch attachments.js < 17151_redmine_2.3_latest.patch
</pre>
--------------------------------------------------------------------------------
Thank you
--------------------------------------------------------------------------------
I'm running Redmine 2.5.1 and started having that problem with the latest Chrome update, version 36.0.1985.125 m. Is it fixed in 2.5.2? Is there a patch for 2.5.1?
--------------------------------------------------------------------------------
Vinicius Ferreira wrote:
> Is it fixed in 2.5.2?
Yes.
version:2.5.2 includes version:2.4.6 fixes.
--------------------------------------------------------------------------------
I'm also running *Redmine 2.5.1* is there any patch for it? Or can I use the attachments.js and _form.html.erb from 2.5.2 in 2.5.1 to fix this bug?
--------------------------------------------------------------------------------
red dot wrote:
> I'm also running *Redmine 2.5.1* is there any patch for it?
http://www.redmine.org/projects/redmine/repository/revisions/13201/diff?format=diff
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Hi guys, firstly, thank you by your effort on fixing it!
I'm using a BitNami package - 2.5.2 and I've just migrate from 2.4.1 and I would like to share with you guys that I had to run the following commands on MySQL, in order to run 2.5.2 correctly (it was need due my customized fields ;)
<pre>
use bitnami_redmine
ALTER TABLE custom_fields ADD format_store TEXT(65535);
ALTER TABLE custom_fields ADD description TEXT(65535);
</pre>
Tks again!
Fernando Sampaio
--------------------------------------------------------------------------------
Toshi MARUYAMA wrote:
> red dot wrote:
> > I'm also running *Redmine 2.5.1* is there any patch for it?
>
> http://www.redmine.org/projects/redmine/repository/revisions/13201/diff?format=diff
How to use it? - solved
I'm use it, and it's not solve my problem.
I have same ussue like in top screen on 2.5.1.
--------------------------------------------------------------------------------
seyfer seed wrote:
> Toshi MARUYAMA wrote:
> > red dot wrote:
> > > I'm also running *Redmine 2.5.1* is there any patch for it?
> >
> > http://www.redmine.org/projects/redmine/repository/revisions/13201/diff?format=diff
>
> How to use it? - solved
>
> I'm use it, and it's not solve my problem.
> I have same ussue like in top screen on 2.5.1.
Why not update to version:2.5.2?
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
seyfer seed wrote:
> Toshi MARUYAMA wrote:
> > red dot wrote:
> > > I'm also running *Redmine 2.5.1* is there any patch for it?
> >
> > http://www.redmine.org/projects/redmine/repository/revisions/13201/diff?format=diff
>
> How to use it? - solved
How do you apply?
--------------------------------------------------------------------------------
Toshi MARUYAMA wrote:
> Vinicius Ferreira wrote:
> > Is it fixed in 2.5.2?
>
> Yes.
>
> version:2.5.2 includes version:2.4.6 fixes.
Hi, I still encounter the same problem in 2.5.2.stable.
Any advice?
--------------------------------------------------------------------------------
chu chu wrote:
> Hi, I still encounter the same problem in 2.5.2.stable.
How do you check your version is version:2.5.2?
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
http://goo.gl/htEwxs
> This issue should be fixed by 36.0.1985.143, which was pushed to stable channel yesterday.
--------------------------------------------------------------------------------
Toshi MARUYAMA wrote:
> http://goo.gl/htEwxs
> > This issue should be fixed by 36.0.1985.143, which was pushed to stable channel yesterday.
It works well now,
thank you!
--------------------------------------------------------------------------------
related_issues
relates,Closed,13932,File upload does not work with Safari
duplicates,Closed,17366,Add duplicate files on chrome on Windows7 64bit
duplicates,Closed,17495,Problem attaching files using Chrome ver. 36.0.1985.125 m and Button "Select files"
duplicates,Closed,17533,Attach File Broken in Chrome
duplicates,Closed,17528,AJAX uploading shows multiple uploads and inputs
duplicates,Closed,17536,File attachment bug in the new version of chrome.
duplicates,Closed,17559,Same file gets Attach at atime with 21 FileUpload fields and other 8 uploading status on waiting.
duplicates,Closed,17606,Reproduction of forms to add files in the browser Google Chrome!
duplicates,Closed,17653,Layout is broken when using chrome to upload an attachment
duplicates,Closed,17665,Attachment upload called twice using Chrome
duplicates,Closed,17677,When upload file, program show multi control upload and duplication current file upload