プロジェクト

全般

プロフィール

Vote #75725

完了

Issue performance patch

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Code cleanup/refactoring_30
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
30
version_id:
80
issue_org_id:
18290
author_id:
111145
assigned_to_id:
1
comments:
3
status_id:
5
tracker_id:
3
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

Issue safe_attribute 'is_private' cause a author loading if not necessary in some situations, and status_id_was is same as status_id, and it is not preventing loading if not changed.

Please accept, I hate patch all method, cuz one line change :(


journals

--------------------------------------------------------------------------------
The author load fix is committed in r13576.

The second part is not OK and breaks a bunch of tests because @#status_was@ would return nil if status was not changed, where it should return the current status. Fixed in r13577.

The last part is no longer in sync with trunk.

Thanks for your submission.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------


related_issues

duplicates,Closed,17880,Performance issues on Issue model

Admin Redmine さんが約4年前に更新

  • カテゴリCode cleanup/refactoring_30 にセット
  • 対象バージョン3.0.0_80 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0