Vote #75918: TimeEntry acts_as_activity_provider scope should joins(:project) - redmineorg-copy202205 - Redmine

編集操作

リンクをコピー

Vote #75918

完了

TimeEntry acts_as_activity_provider scope should joins(:project)

Admin Redmine さんが4年以上前に追加. 4年以上前に更新.

ステータス:

Closed

優先度:

通常

担当者:

カテゴリ:

Code cleanup/refactoring_30

対象バージョン:

3.0.0_80

開始日:

2022/05/09

期日:

進捗率:

予定工数:

Redmineorg_URL:

https://www.redmine.org/issues/18818

category_id:

version_id:

issue_org_id:

18818

author_id:

111145

assigned_to_id:

comments:

status_id:

tracker_id:

plus1:

affected_version:

closed_on:

affected_version_id:

ステータス-->[Closed]

引用

説明

TimeEntry acts_as_activity_provider scope should join project, not just preload it

journals

--------------------------------------------------------------------------------
Committed in r13971, thanks.
--------------------------------------------------------------------------------
For the record:

:scope => preload(:project) was introduced by r13482 (#14534).

<pre><code class="diff">
=== (+11,-5) app/models/time_entry.rb ===
@@ -35,7 +35,7 @@

acts_as_activity_provider :timestamp => "#{table_name}.created_on",
:author_key => :user_id,
- :find_options => {:include => :project}
+ :scope => preload(:project)

</code></pre>

So target version:3.0.0 is no need.
But version:3.0.0 was already released.
--------------------------------------------------------------------------------