プロジェクト

全般

プロフィール

Vote #75971

完了

rdm-mailhandler.rb should catch EOFError

Admin Redmine さんが3年以上前に追加. 3年以上前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Email receiving_29
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
29
version_id:
89
issue_org_id:
18922
author_id:
332
assigned_to_id:
1
comments:
5
status_id:
5
tracker_id:
1
plus1:
0
affected_version:
closed_on:
affected_version_id:
88
ステータス-->[Closed]

説明

rdm-mailhandler.rb should catch EOFError in addition to SystemCallError at source:trunk/extra/mail_handler/rdm-mailhandler.rb@13872#L132.

If communications between rdm-mailhandler.rb and Redmine are terminated while rdm-mailhandler.rb talking to Redmine, Net::HTTP raises EOFError and rdm-mailhandler stops unexpectedly because it does not catch EOFError. The email will be bounced.

error mail from MTA

We can avoid the preceding by this patch. The email will be deferred, not bounced.


journals

Maybe we could even catch IOError which is the superclass of EOFError?
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> Maybe we could even catch IOError which is the superclass of EOFError?

Indeed. To deal with a variety of situations, catching IOError is better solition.
Thank you for pointing it out.

--------------------------------------------------------------------------------
Here is a new patch. Catches IOError instead of EOFError.
--------------------------------------------------------------------------------
Patch committed in r13961, thanks.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

Admin Redmine さんが3年以上前に更新

  • カテゴリEmail receiving_29 にセット
  • 対象バージョン2.6.2_89 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0