Vote #75971
完了rdm-mailhandler.rb should catch EOFError
0%
説明
rdm-mailhandler.rb should catch EOFError in addition to SystemCallError at source:trunk/extra/mail_handler/rdm-mailhandler.rb@13872#L132.
If communications between rdm-mailhandler.rb and Redmine are terminated while rdm-mailhandler.rb talking to Redmine, Net::HTTP raises EOFError and rdm-mailhandler stops unexpectedly because it does not catch EOFError. The email will be bounced.
We can avoid the preceding by this patch. The email will be deferred, not bounced.
journals
Maybe we could even catch IOError which is the superclass of EOFError?
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> Maybe we could even catch IOError which is the superclass of EOFError?
Indeed. To deal with a variety of situations, catching IOError is better solition.
Thank you for pointing it out.
--------------------------------------------------------------------------------
Here is a new patch. Catches IOError instead of EOFError.
--------------------------------------------------------------------------------
Patch committed in r13961, thanks.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------