--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
That's a good start but here are a few things that need to be changed:

* I'll prefer to keep only one resource for project files, which would be @/projects/:project_id/files@, so we should remove the alternate @POST /projects/foo/versions/123/files@ to create a file associated to a version (@POST /projects/foo/files@ with a version_id attribute will be used instead).

* @POST /projects/:project_id/files@ should create a single file with the file attributes given in a "file" hash (instead of @attachments / file_1@ ), eg.

<pre>
{ "file": {
"filename": "foo",
...
}
</pre>

* @GET /projects/:project_id/files@ should include the names of author and version (if any), just like it's done for the issues, eg.:

api.author(:id => file.author_id, :name => file.author.name)

* Maybe should simply use the AttachmentsHelper#render_api_attachment to format most of the file attributes

* We don't keep track of authors in the source code

* I hold the copyright for the Redmine source code, I can't include a source file that is copyrighted to a third-party in the core.
--------------------------------------------------------------------------------
Thanks for the feedback, I'll modify my patch.

Concerning the POST request, would the following JSON be acceptable ?
<pre>
{ "project": {
"version_id": "123",
"files": [
{ "filename": "file_1",
"description": "",
"content_type": "",
"token": "foo_1"
},
{ "filename": "file_2",
"token": "foo_2"
}
]
}
}
</pre>
Where version_id, filename, description and content_type are optional parameters.

This way it will be possible to handle several files at once (as done in the IssuesController).
--------------------------------------------------------------------------------
Here is the updated patch.
The expected JSON format is
<pre>
{ "file": {
"filename",
...
}
}
</pre>

I used the AttachmentsHelper#render_api_attachment, which I've modified to accept additional options (in order to diplay the version_id).
I can remove this modification if necessary.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Any chance this will be part of an upcoming release? :)
--------------------------------------------------------------------------------
What's the status on this feature? Sure would be helpful.
--------------------------------------------------------------------------------
The patch 0001-REST-API-add-files-REST-API_v2.patch cannot be applied to current trunk (r15012).

<pre>
$ patch -p1 < 0001-REST-API-add-files-REST-API_v2.patch
patching file app/controllers/files_controller.rb
Hunk #3 FAILED at 49.
1 out of 3 hunks FAILED -- saving rejects to file app/controllers/files_controller.rb.rej
patching file app/helpers/attachments_helper.rb
patching file app/views/files/index.api.rsb
patching file test/integration/api_test/api_routing_test.rb
patching file test/integration/api_test/files_test.rb
</pre>
--------------------------------------------------------------------------------
Updated Patch from Hg attached. We are currently using on 3.3 with no issues.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Committed in r16109 with a few changes to the index response. Thanks.
--------------------------------------------------------------------------------

relates,Closed,7725,REST API for files
relates,New,18245,Documents REST API
relates,New,13800,File REST API