Vote #76494
完了Make the updateIssueFrom(url) function return the XMLHttpRequest object
0%
説明
The current javascript function @updateIssueFrom(url)@ does not return anything.
If we could just return the XMLHttpRequest object (as it is returned by the @ajax()@ call), it would allow us to chain methods like this:
updateIssueFrom(url).done(function() {
$( this ).addClass( "done" );
});
Here is the patch:
diff --git a/public/javascripts/application.js b/public/javascripts/application.js
--- a/public/javascripts/application.js
+++ b/public/javascripts/application.js
@@ -471,7 +471,7 @@ function updateIssueFrom(url) {
$('#all_attributes input, #all_attributes textarea, #all_attributes select').each(function(){
$(this).data('valuebeforeupdate', $(this).val());
});
- $.ajax({
+ return $.ajax({
url: url,
type: 'post',
data: $('#issue-form').serialize()
This simple patch could really help me to simplify my Redmine plugins. Thank you.
journals
Committed in r14372, thanks.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
FTR the object returned by the function is not a XMLHttpRequest but a Promise.
--------------------------------------------------------------------------------
Admin Redmine さんが約4年前に更新
- カテゴリ を Code cleanup/refactoring_30 にセット
- 対象バージョン を 3.1.0_90 にセット