Vote #76497
未完了IssueLink in email notification contains SUB-URI part twice
0%
説明
I am using Redmine installed in SUB-URI environment for a long time now I plan to upgrade from 2.5.3 into 3.0.3. So I have started testing it before I upgrade my production environment. Everything looks good only one problem I have recognized.
When I receive an email notification from Redmine 3.0.3 installed in sub-uri environment, the URL contains the SUB-URI part twice
like this http://server.domain/redmine/redmine/issues/1234#change-12345
All of the other URL-s are working properly in my Redmine environment.
My general site settings contains only server.domain without the sub-uri part.
If I use Redmine 2.5 or 2.6 versions with exactly the same setup everything work as expected.
I have installed everything with SVN checkout and the suggested building procedure.
All of the functionality in redmine works perfect only the URLs in email notifications are wrong (SUB-URI part doubled).
I have checked the app/models/mailer.rb file and I have found an important change compared to earlier versions:
In 2.5 and 2.6 it was:
def self.default_url_options
{ :host => Setting.host_name, :protocol => Setting.protocol }
end
In 3.0.3 it is:
def self.default_url_options
options = {:protocol => Setting.protocol}
if Setting.host_name.to_s =~ /\A(https?:\/\/)?(.+?)(:(\d+))?(\/.+)?\z/i
host, port, prefix = $2, $4, $5
options.merge!({
:host => host, :port => port, :script_name => prefix
})
else
options[:host] = Setting.host_name
end
options
end
I have changed the :script_name attribute in the 31st line like this:
:script_name => ''
So the function now looks like:
def self.default_url_options
options = {:protocol => Setting.protocol}
if Setting.host_name.to_s =~ /\A(https?:\/\/)?(.+?)(:(\d+))?(\/.+)?\z/i
host, port, prefix = $2, $4, $5
options.merge!({
:host => host, :port => port, :script_name => ''
})
else
options[:host] = Setting.host_name
end
options
end
And the problem is solved but I would like to be sure is this solution does not generates other unexpected behaviour.
My environment is:
Environment:
Redmine version 3.0.3.stable.14377
Ruby version 2.0.0-p0 (2013-02-24) [x86_64-linux]
Rails version 4.2.3
Environment production
Database adapter Mysql2
SCM:
Subversion 1.6.9
Git 1.7.11.3
Filesystem
Redmine plugins:
clipboard_image_paste 1.10
quick_edit 0.0.8
redmine_agile 1.3.9
redmine_ckeditor 1.1.0
redmine_dashboard 2.5.0
redmine_helpdesk 0.0.12
redmine_my_page 0.1.5
redmine_per_project_formatting 0.0.4
redmine_theme_changer 0.2.0
redmine_wiki_unc 0.0.3
redmine_work_time 0.3.0
redmine_xlsx_format_issue_exporter 0.1.2
Thx. for your help
journals
This is my apache configuration:
<pre>
FastCgiServer /data/redmine/public/dispatch.fcgi \
-idle-timeout 120 -processes 2 \
-initial-env RAILS_ENV=production \
-initial-env PATH=/data/ruby/bin:/usr/bin \
-initial-env LD_LIBRARY_PATH=/data/tools/lib \
-initial-env RAILS_RELATIVE_URL_ROOT=/redmine
Alias /redmine /data/redmine/public
<Directory /data/redmine/public>
Options Indexes ExecCGI FollowSymLinks
RewriteEngine On
RewriteBase /redmine
RewriteCond %{REQUEST_FILENAME} !-f
RewriteRule ^(.*)$ dispatch.fcgi
AllowOverride all
Order allow,deny
Allow from all
</Directory>
</pre>
in redmine/config/environment.rb
<pre>
RedmineApp::Application.routes.default_scope = {
:path => ENV['RAILS_RELATIVE_URL_ROOT'],
:shallow_path => ENV['RAILS_RELATIVE_URL_ROOT']
}
</pre>
--------------------------------------------------------------------------------
It seems #19323 regression.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I've made a test with your change to environment.rb, and don't get the double sub-uri if I set the "Host name and path" (in application settings / General tab) to the host name only, without the sub-uri path (eg. redmine.host). Can you double check that?
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I can confirm the problem. The workaround does help me!
Though I think I don't have the same situation. Hard to describe what my situation is, actually... ;-) Has something to do with passenger. At least I can say all worked fine except the emails. With this hack it also works for me with Redmine 3.1.0 and 3.2.0.
--------------------------------------------------------------------------------
I'm wondering why prefix (or :script_name) gets populated. In my case Setting.host_name is set to @redmine.colop.com@, so there is no @/something@ appended to the host. Links should be @redmine.colop.com/something@ but actually get rendered to @redmine.colop.com/something/something@.
In my case @config/additional_environment.rb@ and @config/environments/production.rb@ are not modified. relative_url_root is not changed that way. And my httpd-conf contains:
<pre><VirtualHost *:80>
ServerName redmine.colop.com
PassengerRuby /home/redmine/.rvm/wrappers/ruby-2.2.1/ruby
PassengerSpawnMethod smart
PassengerPoolIdleTime 300
PassengerMaxRequests 500
PassengerStatThrottleRate 5
PassengerMinInstances 2
DocumentRoot /var/www/html/redmine/public
Alias /something /var/www/html/redmine/public
<Location "/something">
PassengerBaseURI /something
PassengerAppRoot /var/www/html/redmine
</Location>
<Directory /var/www/html/redmine/public>
Allow from all
Options -MultiViews
# Uncomment this if you're on Apache >= 2.4:
#Require all granted
</Directory>
</VirtualHost></pre>
Does this configuratin inject the host into Redmine configuration? Why can it happen that :script_name is not empty?
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> I've made a test with your change to environment.rb, and don't get the double sub-uri if I set the "Host name and path" (in application settings / General tab) to the host name only, without the sub-uri path (eg. redmine.host). Can you double check that?
At first time I setted
hostname to "host/redmine" in redmnine's preferences
(as redmine suggest, it show under input caption: "Example: host/redmine").
Then, when I saw URL like this "host/redmine/redmine" in mail,
so I changed hostname to just "host", but emails still contains double sub-uri in URL.
But hostname change works, if for example I set hostname to "host/" I got in email
"host//redmine/redmine", as you see it contains "//".
So may be to reproduce bug, you need at first change hostname to "host/redmine",
and then to "host".
--------------------------------------------------------------------------------
Indeed
<pre>
:script_name => ''
</pre>
fixed issue for me.
I add some logging into app/models/mailer.rb:
<pre>
def self.default_url_options
Rails.logger.error "Hi!!!!! It is me!!!!!!!!!!!!!!!!!!"
options = {:protocol => Setting.protocol}
Rails.logger.error "!!!!!!!Setting.host_name.to_s '#{Setting.host_name.to_s}'"
if Setting.host_name.to_s =~ /\A(https?\:\/\/)?(.+?)(\:(\d+))?(\/.+)?\z/i
host, port, prefix = $2, $4, $5
Rails.logger.error "!!!!!!! '#{host}', '#{port}', '#{prefix}'"
options.merge!({
:host => host, :port => port, :script_name => ''
})
else
Rails.logger.error "!!!!!!!ELSE!!!! Setting.host_name '#{Setting.host_name}'"
options[:host] = Setting.host_name
end
options
end
</pre>
It prints:
<pre>
Hi!!!!! It is me!!!!!!!!!!!!!!!!!!
!!!!!!!Setting.host_name.to_s 'hostname.net'
!!!!!!! 'hostname.net', '', ''
</pre>
So prefix is empty, but not as empty string.
Because of
<pre>
:script_name => prefix
</pre>
and
<pre>
:script_name => ''
</pre>
give different results.
--------------------------------------------------------------------------------
related_issues
relates,Closed,19323,Incorrect links generated in emails if host setup uses other port (":" symbol)
duplicates,Closed,23182,url in email + sub uri = sub uri duplication