Vote #76509
完了Time entry query : column week
0%
journals
Here is the patch working on any version of Redmine.
Please feel free to integrate this straightforward patch
--------------------------------------------------------------------------------
Could you add tests?
* source:tags/3.1.0/test/unit/time_entry_query_test.rb
* source:tags/3.1.0/test/functional/timelog_controller_test.rb
--------------------------------------------------------------------------------
Here is a patch, only the unit test, there is no controller test about queries available columns
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Does it make sense to display the week number without the year? Sorting on this column will result in time entries from different years appear with the same week.
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> Does it make sense to display the week number without the year? Sorting on this column will result in time entries from different years appear with the same week.
I don't see a use case that makes this sort useful, but on the other hand displaying this column is useful to have the week number without duplicating informations in other columns (spent_on). The yyyy-ww sort can be done with spent_on.
Thank to have added this patch to 3.2.0
If you have some time to review my other pending patches I will be very pleased !
--------------------------------------------------------------------------------
Jérôme BATAILLE wrote:
> I don't see a use case that makes this sort useful
Just asking... because the patch makes it sortable.
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> Just asking... because the patch makes it sortable.
We are at the frontier of YAGNI :-) I can't see a use case, but perhaps some folks will, and adding the sort costs nothing.
--------------------------------------------------------------------------------
Column added in r14723. But sort is done on spent_on, as sorting by week number does make no sense when we have time entries on several years.
--------------------------------------------------------------------------------
Thanks a lot !
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,Closed,26780,Translation for label_week in time report is not working