Vote #76700
完了Show visible spent time link for users allowed to view time entries.
0%
説明
With this little change, the spent time is back, but showing only hours visible by the user according to the new "time log visibility" permission.
journals
There are many "show.html.erb". Which show.html.erb?
--------------------------------------------------------------------------------
@app/views/issues/show.html.erb@
Thanks
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
+1
Works great on 3.3.1. Thanks.
--------------------------------------------------------------------------------
By this patch, different spent hours value is displayed for each user.
I am worried that it may cause confusion.
--------------------------------------------------------------------------------
Go MAEDA wrote:
> By this patch, different spent hours value is displayed for each user.
> I am worried that it may cause confusion.
It already work in this way in multiple places (issues list for example) - user can see only his own time log.
Personally I think that much more confusing is situation, where issues list contain more details about issue than issue detail view, and user can't easily see how many hours his spend on the issue.
--------------------------------------------------------------------------------
Robert Korulczyk wrote:
> Go MAEDA wrote:
> > By this patch, different spent hours value is displayed for each user.
> > I am worried that it may cause confusion.
>
> It already work in this way in multiple places (issues list for example) - user can see only his own time log.
Thank you for letting me know it. I didn't know. I agree with you now. I think that it is inconsistent.
!{border: 1px solid #ccc;}.spent-time-issues-index.png!
!{border: 1px solid #ccc;}.spent-time-issues-show.png!
--------------------------------------------------------------------------------
Updated the patch.
Also @Issue.load_visible_total_spent_hours@ should be called to show correct value of @total_spent_hours@.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Let's resolve the inconsistency.
Setting target version to 3.3.3.
--------------------------------------------------------------------------------
Committed, thanks.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,Closed,25526,Revert API change in spent_hours field in issue#show