プロジェクト

全般

プロフィール

Vote #76787

完了

Fix mulitple tab navigation highlighting and content hiding

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
Code cleanup/refactoring_30
対象バージョン:
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
30
version_id:
106
issue_org_id:
20906
author_id:
121548
assigned_to_id:
1
comments:
4
status_id:
5
tracker_id:
3
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

Assuming you have multiple tab navigations on one page, clicking on a tab leads to the false behaviour that highlighted tabs in another tab navigation lose their highlighting. This is caused by the current implementation of showTab in application.js, because it only assumes the case of having only one tab navigation on one page (see source:trunk/public/javascripts/application.js#L319). This assumption also causes the behaviour, that all elements that match the selector

div#content .tab-content

will be hidden if one tab is clicked (see source:trunk/public/javascripts/application.js#L318).

The attached patch takes the possibility of having several tab navigations into consideration. It does not remove the highlighting for other tab navigations and hides the tab content of the corresponding tab context.


journals

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Committed, thanks.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------


related_issues

relates,Closed,20271,Fix for multiple tabs on the same page

Admin Redmine さんが約4年前に更新

  • カテゴリCode cleanup/refactoring_30 にセット
  • 対象バージョン3.1.2_106 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0