Vote #76930
完了Wiki lists in the sidebar are broken
0%
説明
The list in the Sidebar didn't work anymore since 2.5.X version. The same problem appear with
{{child_pages}} macro.
I tested on demo.redmine.org with the same result.
But if you put an orderer list (with #) it works.
This is due to changes in the Redmine CSS in 2.4.0 that added "lines 80 and 81":/projects/redmine/repository/annotate/trunk/public/stylesheets/application.css#L80 in the main Redmine CSS, see also #13242.
This is my redmine:
Redmine 2.6 Ruby 2.2
journals
Minimal fix for the problem attached:
* Wrap the wiki text a div.wiki (which is required anyway for proper wiki text styling)
* Undo the styles of form @#sidebar xyz@ for @#sidebar div.wiki xyz@ which works but is a bit ugly
The proper fix (IMHO) would be to wrap all content of the sidebar (except the wiki) in its own div with a class, say "content" and then match everything with @#sidebar .content xyz@. This would leave the .wiki stuff unaffected and would not require dirty "counter"-rules in application.css like I did in the minimal fix here.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Daniel Ritz wrote:
> The proper fix (IMHO) would be to wrap all content of the sidebar (except the wiki) in its own div with a class, say "content" and then match everything with @#sidebar .content xyz@. This would leave the .wiki stuff unaffected and would not require dirty "counter"-rules in application.css like I did in the minimal fix here.
Should I implement that or is the minimal fix enough?
--------------------------------------------------------------------------------
Daniel Ritz wrote:
> The proper fix (IMHO) would be to wrap all content of the sidebar (except the wiki) in its own div with a class
Would you do that by adding a div in each view where there is some content for the sidebar?
If so, I'd prefer the patch you've already submitted.
--------------------------------------------------------------------------------
Jean-Philippe Lang wrote:
> Daniel Ritz wrote:
>
> > The proper fix (IMHO) would be to wrap all content of the sidebar (except the wiki) in its own div with a class
>
> Would you do that by adding a div in each view where there is some content for the sidebar?
> If so, I'd prefer the patch you've already submitted.
Yeah, pretty much. Thinking about it some more, the minimal fix is better as it allows sidebar content at any level to insert .wiki and formatted text that just works.
--------------------------------------------------------------------------------
Patch committed, thanks for the feedback.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,Closed,13242,Use <li> tags for lists