Vote #77005
完了IssuePriority.position_name not recalculated every time it should
0%
説明
The @position_name@ attribute of @IssuePriority@ instances is currently only recalculated when the @position@ of the @IssuePriority@ instance changes source:/tags/3.2.0/app/models/issue_priority.rb#L22
However, the @position_name@ should also be recalculated when the @active@ attribute changes.
I would even argue that that operation is quick enough, and that changes to the @IssuePriority@ list are not frequent and done by administrators, so that the recalculation of the @position_name@ can be done on @after_save@ without filtering.
Patch to follow.
journals
--------------------------------------------------------------------------------
Felix Schäfer wrote:
> I would even argue that that operation is quick enough, and that changes to the @IssuePriority@ list are not frequent and done by administrators, so that the recalculation of the @position_name@ can be done on @after_save@ without filtering.
Sure, it's quick enough and this issue would not occur but code that runs when it's actually needed is also a good thing.
Patch committed, thanks.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------