プロジェクト

全般

プロフィール

Vote #77071

未完了

Search in issue assigned dropdown list

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
New
優先度:
通常
担当者:
-
カテゴリ:
UI_10
対象バージョン:
-
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
10
version_id:
0
issue_org_id:
21662
author_id:
142651
assigned_to_id:
0
comments:
17
status_id:
1
tracker_id:
2
plus1:
1
affected_version:
closed_on:
affected_version_id:
ステータス-->[New]

説明

My team used redmine over one year,now there are about 100 people in one project。

Everytime I create a issue ,I must assgin to somebody, and the dropdown list is tooooooo long, really hard to find the people I want to assgin.

sorry about my english,can somebody tell me to do fix it?


journals

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
It would be great if "Assignee" drop-down has incremental search feature like "Jump to project" drop-down improved by #23310.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
+1 for kunkka zhang's idea!

I made the patch to implement this feature (compatible with latest trunk 17004).
This patch alows user to select assigner using incremental search.

Please see the screenshots below for the details.

|!autocomplete-issue-assigned-to_01@2x.png!|!autocomplete-issue-assigned-to_02@2x.png!|

Patch: attachment:autocomplete-issue-assigned-totrunk-r17004.patch
--------------------------------------------------------------------------------
Tomomi Yuzuriha, thank you for contributing to Redmine.

I have just tried your patch and I noticed a problem. The problem is that "<< me >>" in the assignee list is removed by your patch. I think this is a big problem because "<< me >>" is very useful and probably many people use it.

I hope that "<< Me >>" will be available in your patch.
--------------------------------------------------------------------------------
This improvement looks very nice and it'll improve Redmine UI/UX. I'm wondering if it is possible to make this implementation like a widget or JS function that can be reused easily in other parts from Redmine (eg: selects, add watchers, plugins).

--------------------------------------------------------------------------------
Go Maeda, Thank you for your pointting out of my patch's problem.

Refering your comment, I changed the patch as follows.
* Add "<< me >>" in assignee list
* Add separator between Users and Groups

Please see the screenshot and patch below for the details.

!gravatar_icon_none@2x.png!
Patch: attachment:0001-Add-autcomplete-issue-assigned-to.patch

Additionaly, Possible to add gravatar to the assignee list with the following patch.
!gravatar_icon_present@2x.png!
Patch: attachment:0002-Add-display-gravatar-on-assigners-list.patch
--------------------------------------------------------------------------------
Tomomi Yuzuriha - san, +1 !
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
LGTM. Setting the target version to 4.1.0.
--------------------------------------------------------------------------------
I changed the patch because the layout was corrupted as shown below on the specific browser(e.g. chrome, IE).

Layout with chrome:
|!gravatar-icon-none@2x.png!|!gravatar-icon-present@2x.png!|
--------------------------------------------------------------------------------
The screenshots look nice indeed. However, in my view[1] there are some issues with this patch series in its current state[2]:
* I'll start by saying that I agree with what Marius wrote in note#7: "[...] if it is possible to make this implementation like a widget or JS function that can be reused easily in other parts from Redmine (eg: selects, add watchers, plugins)". I actually think it might even be a requirement.
* This functionality is only implemented in the @issues/_attributes.html.erb@ partial, while there are:
** one: more current uses of @principals_options_for_select@ that (might) need the same functionality:
*** @ProjectsHelper#project_default_assigned_to_options@
*** @issues/bulk_edit.html.erb@ view
*** @issue_categories/_form.html.erb@ view
** two: other similar parts of the current Redmine core code and indeed even plugins that could benefit from this change (again referring to Marius' quote here) [two other practical use-cases _I_ though of were the user custom fields and even version selects (with the second one I'm thinking especially about the currently sometimes very long lists)].
This becomes a problem (duplication) when the same functionality is being implemented in those other places too. Because of that it would be better if most of the implementation (logic) is outside of the views/partials. I haven't looked up what the possibilities here exactly are but what about an @ApplicationHelper#principals_options_for_autocomplete@ or something? And what about some extraction/abstraction into (at least) (a) reusable JS function(s)?
* And btw: what about the @raw@ usage? Is is safe? I'd have to look into it more closely.
* Some typo-look-a-like, potentially ambiguous variable names: @assignner_list@ & @assigners@. What about @assignee(s)_list@ & @assignees@?
* What about some top-padding for the groups separator? Maybe a little less padding around the items themselfs? Maybe style the separator like the other opt-group implementations in Redmine[3] by omitting the dashes and making the label bold. I should keep the icon in this case.
* I see several CSS styles and @li@ element styles. Does this affect themes/themeability? Transfer to @application.css@? Responsive styling ok? I haven't tested it.
* This is I think the biggest problem currently: this patch misses an equivalent of @:required => @issue.required_attribute?('assigned_to_id')@ introduced in r9977 for #703 and #3521.

All in all, I don't think that these patches are ready for integration yet.

fn1. disclaimer one: I don't consider myself a JavaScript guru.

fn2. disclaimer two: I haven't actually run this code myself (yet); I only did a (superficial) visual review of the patches from note#12.

fn3. like: r6307, r13662, r15601, r16194.

--------------------------------------------------------------------------------
Mischa The Evil wrote:
> All in all, I don't think that these patches are ready for integration yet.

What is current status?

--------------------------------------------------------------------------------
I think that it is good to use "select2":https://select2.org/ to realize this feature.
It is a plugin that provides an easy-to-use selection box.

This picture is actually a screenshot of the screen using select2.
!{width: 70%; border: 1px solid #ccc}using_select2.png!

select2 is a popular plugin with many stars (22109) in GitHub.
https://github.com/select2/select2

By applying the attached patch you can use select 2 in Redmine for testing.
--------------------------------------------------------------------------------
Select2 could be a good solution, but Jean-Philippe Lang prefers to not use this library because it has a huge footprint (you can see here: #23310-11).

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------


related_issues

relates,New,22275,Could search or input manually assignee and target version
relates,New,1308,use ajax suggestion pattern to fill out single potentially big fields, like "assigned to", "author"
duplicates,Closed,26656,Search Assignee

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0