Vote #77162
完了Improve page header title for deeply nested project structures (+ improved XSS resilience)
0%
説明
Some theme developers (or even Redmine core, see below) may wish to put the project breadcrumbs within the page header title on a separate line, see screenshots attached.
Patch 0001 will add some extra span elements which make this possible for theme CSS. It also improves XSS resilience by using the @safe_join@ helper instead of manually declaring strings @.html_safe@, see "here":http://makandracards.com/makandra/954-don-t-mix-array-join-and-string-html_safe and "here":http://stackoverflow.com/questions/4191028/rails-3-0-2-arrayjoin-html-safe. This patch shouldn't change things for existing themes and could therefore applied to core without any doubt, IMHO.
Patch 0002 actually changes Redmine's core CSS to take advantage of this and display the breadcrumbs on a separate line. I feel it looks better this way, but I realize that this is just my opinion, so I would see this patch as optional and up for discussion.
Old:
New:
journals
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
I have the same problem on some of my projects, so a +1 from me.
--------------------------------------------------------------------------------
Great. I think this should be included in Redmine core.
But breadcrumbs in small and bold font are hard to read with non HDPI devices, especially when displaying CJK characters.
!screenshot-font-comparison.png!
I suggest changing the style to the following:
<pre>
#header h1 .breadcrumbs { display:block; font-size: .6em; font-weight: normal; }
</pre>
--------------------------------------------------------------------------------
Setting target version to 3.3.0.
--------------------------------------------------------------------------------
Go MAEDA wrote:
> I suggest changing the style to the following:
Sounds good to me! I must admit that I hadn't tested with CJK characters, but I agree that all texts should remain readable with all character sets, of course!
--------------------------------------------------------------------------------
Changes committed, thanks.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Hi,
I've upgraded to from *@3.2.3@* to *@3.3.1@*, and now my header wraps even when they're short..
It's definitely cool that headers can be styled differently now, and wrap nicely when dealing with _super-long-project-names_, but for me we have two sub-levels max, and our names are short, yet I used to have this:
!2016-11-30_old_redmine_header.png!
Now I have this:
!2016-11-30_new_redmine_header.png!
We use "circle":https://github.com/RCRM/circle/ theme v.2.0.2
Any help/indication on how I can fix this wrapping?
--------------------------------------------------------------------------------
Ben Blanco wrote:
> Hi,
> ...
Please create new issue for feature request, because this issue has closed.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,Closed,7848,Add class for project title in the header
duplicates,Closed,5261,Multiple level subprojects wrap around into the menu