Vote #77267
完了Change "Related issues" label for generic grouped query filters
0%
説明
The helper added to group filters of ":tree" and ":relation" type uses ":label_related_issues" as group label.
module QueriesHelper
include ApplicationHelper
def filters_options_for_select(query)
ungrouped = []
grouped = {}
query.available_filters.map do |field, field_options|
if [:tree, :relation].include?(field_options[:type])
group = :label_related_issues
elsif field =~ /^(.+)\./
# association filters
This is not OK as the helper is for all queries, not only for Issue queries. I my case I have a project query and group title "Related issues" does not match.
I would like to propose creating new, more generic label e.g. "label_related: Related".
journals
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
@field_options[:type]@ is not translated word. It is symbol defined at source:tags/3.2.1/app/models/query.rb#L212 .
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Sebastian Paluch wrote:
> This is not OK as the helper is for all queries, not only for Issue queries. I my case I have a project query and group title "Related issues" does not match.
Does it mean you use plugin which implement project query?
--------------------------------------------------------------------------------
I have past in code that shows you where the <code>:label_related_issues</code> translation is used, I'm not talking about <code>field_options[:type]</code>.
Yes, I have a plugin that implements project queries and in such case group called "Related Issues" is dummy. It should be more generic.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Replaced with :label_relations.
--------------------------------------------------------------------------------
related_issues
relates,Closed,13849,Grouped filters in the filter drop-down
relates,Closed,6118,Filter by parent task or subtasks