Vote #77291
完了Revision Graph and Table should work with vertical-align: middle
0%
説明
The revision list and the Raphael based graph next to it, are currently assumed to be @vertical-align: top@, i.e. the dots representing the commits are always positioned at the top of the table cell. This is a limitation for theme authors. Planio e.g. restyled the table to use @vertical-align: middle@ but now the dots are misplaced.
The patch attached inspects the currently used css properties to properly calculate the dot's position. The patch is targeted at current trunk r15251.
journals
Thanks for the patch. Could you show screenshots of the effect of this patch?
--------------------------------------------------------------------------------
Sure, here we go!
For "educational purpose" I've created a simple theme with the following @application.css@
<pre>
@import url(../../../stylesheets/application.css);
table.changesets td {
vertical-align: middle;
}
</pre>
Using this theme and the current Redmine trunk, I get the following revision table
!theme-without-patch.png!
Using the patch, I get the following
!theme-with-patch.png!
while the default theme still looks as expected
!default-with-patch.png!
This example theme does not make a lot of sense on its own. It was just created for testing. But e.g. Planio's new design uses @vertical-align: middle@ for its tables. (Planio already has the patch applied.)
!planio-with-patch.png!
--------------------------------------------------------------------------------
Thanks, I understand.
Setting target version to 3.2.2.
--------------------------------------------------------------------------------
Committed, thanks.
--------------------------------------------------------------------------------