Vote #77491
完了Moving a wiki page to a different project should refresh parent page list
0%
説明
When renaming a wiki page in order to move it to a different project, I change the Project in the renaming form first. But, the Parent page pick list is not updated according to the selected project. Therefore, it's not possible to set a parent from the target project and I can move it to the root only.
A wrong selection of the Parent page leads to "Parent page doesn't belong to the same project" error then.
I think that the Parent page pick list should be always filled in according to the Project selection.
!wiki_renaming.png!
journals
--------------------------------------------------------------------------------
This problem still exists.
I wrote a patch to solve this problem.
When this patch is applied, the list of Parent Page will change according to Project change.
--------------------------------------------------------------------------------
Mizuki ISHIKAWA wrote:
> I wrote a patch to solve this problem.
Nice. Thanks for sharing it here. Can you add some test coverage for this?
--------------------------------------------------------------------------------
Thank you for reviewing the patch, Mischa The Evil.
Mischa The Evil wrote:
> Mizuki ISHIKAWA wrote:
> > I wrote a patch to solve this problem.
>
> Nice. Thanks for sharing it here. Can you add some test coverage for this?
Since there is almost no Ruby code in this patch, so I thought there was no test that could be added.
Is there a place where you can write tests from the perspective of you?
--------------------------------------------------------------------------------
The patch swaps the positions of "Parent page" and "Project" field. Is it necessary?
--------------------------------------------------------------------------------
Parent page will be changed by Project change.
If there is a “Parent page" above “Project” (current), I think there is a possibility that I do not notice that the list of “Parent page" has been changed.
If there is a "Parent page" is under "Project", I thought that I could perform an intuitive operation in order from top to bottom, so I changed it.
This change is not absolutely necessary.
--------------------------------------------------------------------------------
Although Jean-Philippe Lang set the target version to "Candidate for next minor release", I am setting target version to 4.0.0 because the proposed patch changes the UI (swaps the positions of "Parent page" and "Project" field).
--------------------------------------------------------------------------------
Committed. Thank you for improving Redmine.
--------------------------------------------------------------------------------