Vote #77493
完了Links to issue notes should highlight the linked note
0%
説明
When I follow e.g. the link #4806#note-9, the issue page opens without any indication where the linked note is: The web browser cannot scroll it to the top, because it is one of the last notes.
It would be very helpful to have the linked note visually emphasized it this case, e.g. by using a lightly colored background.
journals
--------------------------------------------------------------------------------
I wrote a patch to implement this feature.
Please see the attached gif animation: attachment:click_the_link.gif
--------------------------------------------------------------------------------
I am sure this feature can improve UX. "Discourse":https://www.discourse.org/ (open source discussion board software) has similar feature. You can try highlight feature of Discourse by clicking https://meta.discourse.org/t/educate-users-about-paragraphs/65220/9 .
The patch from Mizuki Ishikawa looks good to me but I think it is safer to change the patch as follows:
<pre><code class="diff">
--- highlight_the_linked_note.patch.org 2017-06-28 13:44:46.000000000 +0900
+++ highlight_the_linked_note.patch 2017-06-28 13:45:00.000000000 +0900
@@ -12,7 +12,7 @@
+ $(window).on('load hashchange',function(){
+ var hash = location.hash;
+ if (hash){
-+ $('div' + hash).css('background-color', '#ffffdd').animate({backgroundColor: ''}, 2000);
++ $('#history div' + hash).css('background-color', '#ffffdd').animate({backgroundColor: ''}, 2000);
+ }
+ });
+});
</code></pre>
--------------------------------------------------------------------------------
+1 Nice improvement!
--------------------------------------------------------------------------------
I slightly changed the patch. The new patch checks if the format of the fragment identifier is "#change-nnn" or "#note-nnn".
--------------------------------------------------------------------------------
Updated my patch. Replaced a color value with a CSS class in the view.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
+1
--------------------------------------------------------------------------------
Committed, thanks. I've made the transition a bit longer and changed the color.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Thanks to everyone involved!
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
related_issues
relates,Closed,28330,Links to wiki headings should highlight the linked heading
relates,Closed,30834,Links to forum replies should highlight the linked reply
duplicates,Closed,15410,Highlighting of comment anchors