プロジェクト

全般

プロフィール

Vote #77502

未完了

Replace ImageMagick thumbnail creating with GD Graphics Library aka libgd

Admin Redmine さんが約4年前に追加. 約4年前に更新.

ステータス:
New
優先度:
通常
担当者:
-
カテゴリ:
Attachments_19
対象バージョン:
-
開始日:
2022/05/09
期日:
進捗率:

0%

予定工数:
category_id:
19
version_id:
0
issue_org_id:
22995
author_id:
14446
assigned_to_id:
0
comments:
1
status_id:
1
tracker_id:
2
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[New]

説明

Currently image thumbnails are created using shell outs to ImageMagick's convert tool.

There are multiple reason, why this might need to be changed. I do not want to list them here though, since they are largely fueled by "FUD":https://en.wikipedia.org/wiki/Fear,_uncertainty_and_doubt. Nevertheless, the latest ImageMagick security bug lead us to investigate alternatives to create thumbnails.

We came up with the following patch, which uses GD Graphics Library aka gdlib, gdlib2, or gdlib3.

The changes

  • remove the newly introduced dependency to mimemagic, since there is no immediate need to verify the mime type of the image anymore.
  • use the @local-fastimage_resize@ gem[1] to perform the transformation.
  • remove support for BMPs since libgd does not support them in all cases

Please note, that this will probably not work on Windows or JRuby, since interaction with libgd is done via its C API in a native c extension of the fastimage_resize gem.


fn1. "local-fastimage_resize":https://github.com/planio-gmbh/local-fastimage_resize is a fork of "fastimage_resize":https://github.com/sdsykes/fastimage_resize. We've created the fork to remove support for remote image handing, which was not needed in the Redmine use case.


journals

--------------------------------------------------------------------------------


related_issues

relates,Closed,30492,Replace RMagick with MiniMagick

Admin Redmine さんが約4年前に更新

  • カテゴリAttachments_19 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0