Generated patch from JW Fuchs's config_de.yml: attachment:de-update-23388.diff
Could anyone who understand the German language review this?
--------------------------------------------------------------------------------
Looks good to me!

However, please don't change the label "@label_day_plural@"!

_Tage_ is perfectly well! Example:
* Duration: 2 days – Dauer: 2 Tage

The proposed change _Tagen_ is used in other context:
* In/Since 2 days – In/Seit 2 Tagen

But I don't think that this grammatical issue can be distinguished by Redmine at the moment. So I would stick to the "normal" plural form.
--------------------------------------------------------------------------------
Tobias Fischer wrote:
> Looks good to me!
>
> However, please don't change the label "@label_day_plural@"!
>
> _Tage_ is perfectly well! Example:
> * Duration: 2 days – Dauer: 2 Tage
>
> The proposed change _Tagen_ is used in other context:
> * In/Since 2 days – In/Seit 2 Tagen
>
> But I don't think that this grammatical issue can be distinguished by Redmine at the moment. So I would stick to the "normal" plural form.

Understood, this label change is not necessary. We had some users at our company complain about this minor issue so I suggested this change. We did not come across the use as in "since x days" as we're not using the time tracking module.
--------------------------------------------------------------------------------
Alright.

I updated the patch and removed the proposed change for @label_day_plural@

I also changed another string on the fly:
<pre>
[old] notice_failed_to_save_time_entries: "Gescheitert %{count} Zeiteinträge für %{total} von ausgewählten: %{ids} zu speichern."
[proposed] notice_failed_to_save_time_entries: "Gescheitert %{count} Zeiteinträge für %{total} von ausgewählten %{ids} zu speichern."
[final] notice_failed_to_save_time_entries: "%{count} von %{total} ausgewählten Zeiteinträgen konnte(n) nicht gespeichert werden: %{ids}"
</pre>

My @[final]@ change was made to align the failure notice with the other notice for tickets:
<pre>
notice_failed_to_save_issues: "%{count} von %{total} ausgewählten Tickets konnte(n) nicht gespeichert werden: %{ids}."
</pre>

IMHO, this sounds a lot better...
--------------------------------------------------------------------------------
Tobias Fischer, thanks for reviewing this patch.
Setting target version to 3.3.1.
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Hey, while on the subject of german translations - could you change the the @label_me@ for the assignee selection from

_ich_ to _mich_ (_Zugewiesen an: ich_ is grammatically incorrect)

--------------------------------------------------------------------------------
Luka Lüdicke wrote:
> Hey, while on the subject of german translations - could you change the the @label_me@ for the assignee selection from
>
> _ich_ to _mich_ (_Zugewiesen an: ich_ is grammatically incorrect)

I haven't checked yet myself, but we need to make sure that @label_me@ isn't used in any other context througout the code where "ich" would be more appropriate. In that case we would have just improved one place while making other(s) worse :)

--------------------------------------------------------------------------------
Hello,

in my opinion, the seperator and delimiter have to be changed. In Germany you write down numbers the other way.

So this one:
<pre>
number:
# Default format for numbers
format:
separator: ','
delimiter: '.'
</pre>
needs to be changed to this one:
<pre>
number:
# Default format for numbers
format:
separator: '.'
delimiter: ','
</pre>
Technically you have to use a space ' ' as separator, because the dot '.' is only used in currency. But the space is not that common like the dot.

https://docs.oracle.com/cd/E19455-01/806-0169/overview-9/index.html
--------------------------------------------------------------------------------
Philipp Prangenberg wrote:
> Hello,
>
> in my opinion, the seperator and delimiter have to be changed. In Germany you write down numbers the other way.

Hello and welcome to Redmine :-) Please open a new issue for every bug or feature request. If you add a new bug report to an existing issue, it becomes incredibly hard to keep track.

To respond to your request: In Rails, the *delimiter* separates thousands and the *separator* separates integer and fractional part (some call it the "radix point":https://en.wikipedia.org/wiki/Radix_point), see http://api.rubyonrails.org/classes/ActionView/Helpers/NumberHelper.html.

Therefore, the values for the German locale are correct as they are in Redmine and don't need changing.
--------------------------------------------------------------------------------
Toshi, more stuff needs to be committed or can we close? Thanks.
--------------------------------------------------------------------------------
No more commits.
--------------------------------------------------------------------------------

copied_to,Closed,23725,Updated Brazilian translation for 3.3.0.stable